diff --git a/Documentation/prolog-cookbook.txt b/Documentation/prolog-cookbook.txt index 80f92a3312..b1710a20f8 100644 --- a/Documentation/prolog-cookbook.txt +++ b/Documentation/prolog-cookbook.txt @@ -303,11 +303,11 @@ Testing submit rules The prolog environment running the `submit_rule` is loaded with state describing the change that is being evaluated. The easiest way to load this state is to test your `submit_rule` against a real change on a running gerrit instance. The command -link:cmd-test-submit-rule.html[test-submit-rule] loads a specific change and executes +link:cmd-test-submit-rule.html[test-submit rule] loads a specific change and executes the `submit_rule`. It optionally reads the rule from from `stdin` to facilitate easy testing. ==== - cat rules.pl | ssh gerrit_srv gerrit test-submit-rule I45e080b105a50a625cc8e1fb5b357c0bfabe6d68 -s + cat rules.pl | ssh gerrit_srv gerrit test-submit rule I45e080b105a50a625cc8e1fb5b357c0bfabe6d68 -s ==== Prolog vs Gerrit plugin for project specific submit rules diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties index c767f84075..4459bacb67 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties @@ -22,8 +22,8 @@ projects = All projects projectRepoBrowser = Repository Browser useContentMerge = Automatically resolve conflicts useContributorAgreements = Require a valid contributor agreement to upload -useSignedOffBy = Require Signed-off-by in commit message -requireChangeID = Require Change-Id in commit message +useSignedOffBy = Require Signed-off-by in commit message +requireChangeID = Require Change-Id in commit message headingMaxObjectSizeLimit = Maximum Git object size limit headingGroupOptions = Group Options isVisibleToAll = Make group visible to all registered users. diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java index f09015b8e8..c4d06d2be7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java @@ -509,7 +509,7 @@ public class MergeOp { if (rw.isMergedInto(commit, branchTip)) { commit.statusCode = CommitMergeStatus.ALREADY_MERGED; try { - setMergedPatchSet(chg.getId(), ps.getId()); + setMerged(chg, null); } catch (OrmException e) { log.error("Cannot mark change " + chg.getId() + " merged", e); } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommandProvider.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommandProvider.java index c7594bc6d1..ce1da95fed 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommandProvider.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommandProvider.java @@ -60,10 +60,7 @@ public class DispatchCommandProvider implements Provider { return new RegistrationHandle() { @Override public void remove() { - if (!m.remove(name.value(), commandProvider)) { - throw new IllegalStateException(String.format( - "can not unregister command: %s", name.value())); - } + m.remove(name.value(), commandProvider); } }; } @@ -71,11 +68,12 @@ public class DispatchCommandProvider implements Provider { public RegistrationHandle replace(final CommandName name, final Provider cmd) { final ConcurrentMap m = getMap(); - m.put(name.value(), new CommandProvider(cmd, null)); + final CommandProvider commandProvider = new CommandProvider(cmd, null); + m.put(name.value(), commandProvider); return new RegistrationHandle() { @Override public void remove() { - m.remove(name.value(), cmd); + m.remove(name.value(), commandProvider); } }; } diff --git a/plugins/commit-message-length-validator b/plugins/commit-message-length-validator index 9f988c6e5b..45f347d0e2 160000 --- a/plugins/commit-message-length-validator +++ b/plugins/commit-message-length-validator @@ -1 +1 @@ -Subproject commit 9f988c6e5b1e07f66479f0d4d08537281fa4694f +Subproject commit 45f347d0e258ef7b871b046bfa96b9f902063b10 diff --git a/plugins/replication b/plugins/replication index 3fffd16403..d4871d5df6 160000 --- a/plugins/replication +++ b/plugins/replication @@ -1 +1 @@ -Subproject commit 3fffd16403c1d3a4d6f0b13e9f33f4f78df1f6b4 +Subproject commit d4871d5df64d6968f2b256766dc8fa9a8133fdac diff --git a/plugins/reviewnotes b/plugins/reviewnotes index 1fac69b085..d47005095f 160000 --- a/plugins/reviewnotes +++ b/plugins/reviewnotes @@ -1 +1 @@ -Subproject commit 1fac69b085cf67706a3a124df366d55e1976cd21 +Subproject commit d47005095fcf3bc918a1dda62d21988cc6e470e6