opendev/gerrit
Code Issues Proposed changes

PermissionEditor: Use REST API instead of RPC service

Browse Source 
Change-Id: Ib190552e4c4c15ac99373a8c26a86f702e09a785
This commit is contained in:
David Pursehouse
2016-02-18 16:37:01 +09:00
parent 14c66666fe
commit 9f145780c4
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionEditor.java
View File

@@ -14,8 +14,8 @@
package com.google.gerrit.client.admin;
import com.google.gerrit.client.groups.GroupMap;
import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.ui.SuggestUtil;
import com.google.gerrit.common.data.AccessSection;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.common.data.GroupInfo;
@@ -241,14 +241,16 @@ public class PermissionEditor extends Composite implements Editor<Permission>,
// If the oracle didn't get to complete a UUID, resolve it now.
//
addRule.setEnabled(false);
SuggestUtil.SVC.suggestAccountGroupForProject(
projectName, ref.getName(), 1,
new GerritCallback<List<GroupReference>>() {
GroupMap.suggestAccountGroupForProject(
projectName.get(), ref.getName(), 1,
new GerritCallback<GroupMap>() {
@Override
public void onSuccess(List<GroupReference> result) {
public void onSuccess(GroupMap result) {
addRule.setEnabled(true);
if (result.size() == 1) {
addGroup(result.get(0));
if (result.values().length() == 1) {
addGroup(new GroupReference(
result.values().get(0).getGroupUUID(),
result.values().get(0).name()));
} else {
groupToAdd.setFocus(true);
}