opendev/gerrit
Code Issues Proposed changes

Style: labelIndex and labelAsIndex should be CONSTANT_CASE

Browse Source 
Change-Id: Iff175a4fea5a5c0e6b114f2d76bc8cf2e4577c9b
This commit is contained in:
Andrew Bonventre
2016-09-08 11:06:24 -04:00
parent 5554c61ca9
commit 9f35969c6d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java
View File

@@ -47,8 +47,8 @@ public class Permission implements Comparable<Permission> {
public static final String VIEW_DRAFTS = "viewDrafts"; public static final String VIEW_DRAFTS = "viewDrafts";
private static final List<String> NAMES_LC; private static final List<String> NAMES_LC;
private static final int labelIndex; private static final int LABEL_INDEX;
private static final int labelAsIndex; private static final int LABEL_AS_INDEX;
static { static {
NAMES_LC = new ArrayList<>(); NAMES_LC = new ArrayList<>();
@@ -77,8 +77,8 @@ public class Permission implements Comparable<Permission> {
NAMES_LC.add(DELETE_DRAFTS.toLowerCase()); NAMES_LC.add(DELETE_DRAFTS.toLowerCase());
NAMES_LC.add(PUBLISH_DRAFTS.toLowerCase()); NAMES_LC.add(PUBLISH_DRAFTS.toLowerCase());
labelIndex = NAMES_LC.indexOf(Permission.LABEL); LABEL_INDEX = NAMES_LC.indexOf(Permission.LABEL);
labelAsIndex = NAMES_LC.indexOf(Permission.LABEL_AS.toLowerCase()); LABEL_AS_INDEX = NAMES_LC.indexOf(Permission.LABEL_AS.toLowerCase());
} }
/** @return true if the name is recognized as a permission name. */ /** @return true if the name is recognized as a permission name. */
@@ -249,9 +249,9 @@ public class Permission implements Comparable<Permission> {
private static int index(Permission a) { private static int index(Permission a) {
if (isLabel(a.getName())) { if (isLabel(a.getName())) {
return labelIndex; return LABEL_INDEX;
} else if (isLabelAs(a.getName())) { } else if (isLabelAs(a.getName())) {
return labelAsIndex; return LABEL_AS_INDEX;
} }
int index = NAMES_LC.indexOf(a.getName().toLowerCase()); int index = NAMES_LC.indexOf(a.getName().toLowerCase());