opendev/gerrit
Code Issues Proposed changes

ReflogIT: Add test coverage for reflog permissions

Browse Source 
Test that owners and admins can access the reflog, but regular
users cannot.

Change-Id: I358802d190ca12f3bae506aef2acc459478a5269
This commit is contained in:
David Pursehouse 2018-08-22 13:24:07 +09:00
parent e530b33cd5
commit 9f486bd587
1 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/project/ReflogIT.java
View File

@ -19,15 +19,21 @@ import static com.google.common.truth.Truth.assertThat;
import com.google.gerrit.acceptance.AbstractDaemonTest;
import com.google.gerrit.acceptance.PushOneCommit;
import com.google.gerrit.acceptance.UseLocalDisk;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.extensions.api.changes.ReviewInput;
import com.google.gerrit.extensions.api.groups.GroupApi;
import com.google.gerrit.extensions.api.projects.BranchApi;
import com.google.gerrit.extensions.api.projects.ReflogEntryInfo;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.server.git.ProjectConfig;
import com.google.gerrit.server.project.Util;
import java.util.List;
import org.junit.Test;
@UseLocalDisk
public class ReflogIT extends AbstractDaemonTest {
@Test
@UseLocalDisk
public void reflogUpdatedBySubmittingChange() throws Exception {
BranchApi branchApi = gApi.projects().name(project.get()).branch("master");
List<ReflogEntryInfo> reflog = branchApi.reflog();
@ -48,4 +54,33 @@ public class ReflogIT extends AbstractDaemonTest {
reflog = branchApi.reflog();
assertThat(reflog).hasSize(refLogLen + 1);
}
@Test
@UseLocalDisk
public void regularUserIsNotAllowedToGetReflog() throws Exception {
setApiUser(user);
exception.expect(AuthException.class);
gApi.projects().name(project.get()).branch("master").reflog();
}
@Test
@UseLocalDisk
public void ownerUserIsAllowedToGetReflog() throws Exception {
GroupApi groupApi = gApi.groups().create(name("get-reflog"));
groupApi.addMembers("user");
ProjectConfig cfg = projectCache.checkedGet(project).getConfig();
Util.allow(cfg, Permission.OWNER, new AccountGroup.UUID(groupApi.get().id), "refs/*");
saveProjectConfig(project, cfg);
setApiUser(user);
gApi.projects().name(project.get()).branch("master").reflog();
}
@Test
@UseLocalDisk
public void adminUserIsAllowedToGetReflog() throws Exception {
setApiUser(admin);
gApi.projects().name(project.get()).branch("master").reflog();
}
}