opendev/gerrit
Code Issues Proposed changes

Merge "Always auto confirm adding reviewers for set-reviewers SSH command" into stable-2.8

Browse Source
This commit is contained in:
Edwin Kempin
2014-04-10 06:28:45 +00:00
committed by Gerrit Code Review
parent cecf90acc1 1b9a36a091
commit 9f821d2ba9
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
View File

@@ -77,7 +77,7 @@ public class PostReviewers implements RestModifyView<ChangeResource, Input> {
public static class Input { public static class Input {
@DefaultInput @DefaultInput
public String reviewer; public String reviewer;
Boolean confirmed; public Boolean confirmed;
boolean confirmed() { boolean confirmed() {
return Objects.firstNonNull(confirmed, false); return Objects.firstNonNull(confirmed, false);

1
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java
View File

@@ -139,6 +139,7 @@ public class SetReviewersCommand extends SshCommand {
for (String reviewer : toAdd) { for (String reviewer : toAdd) {
PostReviewers.Input input = new PostReviewers.Input(); PostReviewers.Input input = new PostReviewers.Input();
input.reviewer = reviewer; input.reviewer = reviewer;
input.confirmed = true;
String error; String error;
try { try {
error = post.apply(changeRsrc, input).error; error = post.apply(changeRsrc, input).error;