opendev/gerrit
Code Issues Proposed changes

Stop applying unwarranted ellipses to email subjects

Browse Source 
When formatting change emails, change subjects being 61, 62 characters
long, were chopped off to 60 characters and had an ellipsis appended.
Hence, the final 63 character long and mangled change subject was
longer than the original change subject. We now make the effective
change subject of 63 more visible and apply an ellipsis only if
needed.

Change-Id: Ie25095eeb76f718aae0dfb2c82415457a3f69d22
This commit is contained in:
Christian Aistleitner
2013-02-19 20:53:31 +01:00
parent ee7ff53cbb
commit 9fe238ec19
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeSubject.vm
View File

@@ -32,6 +32,6 @@
## subject line for ALL emails related to changes.
##
#macro(elipses $length $str)
#if($str.length() > $length)${str.substring(0,$length)}...#else$str#end
#if($str.length() > $length)#set($length = $length - 3)${str.substring(0,$length)}...#else$str#end
#end
Change in $projectName.replaceAll('/.*/', '...')[$branch.shortName]: #elipses(60, $change.subject)
Change in $projectName.replaceAll('/.*/', '...')[$branch.shortName]: #elipses(63, $change.subject)