opendev/gerrit
Code Issues Proposed changes

PostReview: Remove support for 'strictLabels' option

Browse Source 
Currently we support strict/non-strict label in PostReview,
which is controlled by the 'strictLabels' option.

For strict labels, we require all labels to be within the
user's granted range. Attempting to vote a label value not
granted will fail the entire operation. For non-strict labels,
we squashes the proposed value to the nearest granted value
and the operation will be executed.

This change removes the support for non-strict labels.

Change-Id: Icb9dfafea567e1e9c469811e830e3519b865700f
This commit is contained in:
Changcheng Xiao
2017-07-17 15:00:34 +02:00
committed by David Ostrovsky
parent f87dca186b
commit 9ff64a60c5
8 changed files with 17 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java
View File

@@ -60,7 +60,6 @@ public class ReviewInput extends JavaScriptObject {
private native void init() /*-{
this.labels = {};
this.strict_labels = true;
}-*/;
public final native void prePost() /*-{