opendev/gerrit
Code Issues Proposed changes

Make ls-projects available on HTTP as GET /projects/

Browse Source 
The query string takes the same arguments as the command line tool,
so `ls-projects --type CODE --show-branch foo` can be written out as
`GET /projects/?type=CODE&show-branch=foo`.  Output is identical.

Using /projects/ is anonymous and does not require authentication.
/a/projects/ requires HTTP authentication using the same scheme
that is applied to Git operations over HTTP, typically using the
HTTP password that is generated for a user or SSL certificate auth.

Change-Id: I577ae60eba40cfb358fe41ed8f3cf9481662e738
This commit is contained in:
Shawn O. Pearce
2012-04-05 09:10:02 -07:00
parent 068a0d8dde
commit a041898724
10 changed files with 336 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java
View File

@@ -46,6 +46,7 @@ import org.kohsuke.args4j.NamedOptionDef;
import org.kohsuke.args4j.Option;
import org.kohsuke.args4j.OptionDef;
import org.kohsuke.args4j.spi.BooleanOptionHandler;
import org.kohsuke.args4j.spi.EnumOptionHandler;
import org.kohsuke.args4j.spi.OptionHandler;
import org.kohsuke.args4j.spi.Setter;
@@ -66,7 +67,6 @@ import java.util.ResourceBundle;
* args4j style format prior to invoking args4j for parsing.
*/
public class CmdLineParser {
public interface Factory {
CmdLineParser create(Object bean);
}
@@ -118,6 +118,67 @@ public class CmdLineParser {
out.write('\n');
}
public void printQueryStringUsage(String name, StringWriter out) {
out.write(name);
char next = '?';
List<NamedOptionDef> booleans = new ArrayList<NamedOptionDef>();
for (@SuppressWarnings("rawtypes") OptionHandler handler : parser.options) {
if (handler.option instanceof NamedOptionDef) {
NamedOptionDef n = (NamedOptionDef) handler.option;
if (handler instanceof BooleanOptionHandler) {
booleans.add(n);
continue;
}
if (!n.required()) {
out.write('[');
}
out.write(next);
next = '&';
if (n.name().startsWith("--")) {
out.write(n.name().substring(2));
} else if (n.name().startsWith("-")) {
out.write(n.name().substring(1));
} else {
out.write(n.name());
}
out.write('=');
String var = handler.getDefaultMetaVariable();
if (handler instanceof EnumOptionHandler) {
var = var.substring(1, var.length() - 1);
var = var.replaceAll(" ", "");
}
out.write(var);
if (!n.required()) {
out.write(']');
}
if (n.isMultiValued()) {
out.write('*');
}
}
}
for (NamedOptionDef n : booleans) {
if (!n.required()) {
out.write('[');
}
out.write(next);
next = '&';
if (n.name().startsWith("--")) {
out.write(n.name().substring(2));
} else if (n.name().startsWith("-")) {
out.write(n.name().substring(1));
} else {
out.write(n.name());
}
if (!n.required()) {
out.write(']');
}
}
}
public boolean wasHelpRequestedByOption() {
return parser.help.value;
}