opendev/gerrit
Code Issues Proposed changes

Refactor LabelId out of PatchSetApprovals

Browse Source 
Decouple the LabelId from the PatchSetApprovals so that we can
apply a vote in another context.  Specifically, we may want to
apply a vote(s) to a PatchSetVerification, a separate approval
channel for test results that may verify a single patchset.

Change-Id: Ibb162a6a9249204c24c8751ea01fb816586449dd
This commit is contained in:
David Ostrovsky
2015-01-14 10:58:42 +01:00
committed by David Pursehouse
parent b49af60c23
commit a066f02009
12 changed files with 68 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-common/src/main/java/com/google/gerrit/common/data/LabelType.java
View File

@@ -14,8 +14,8 @@
package com.google.gerrit.common.data;
import com.google.gerrit.reviewdb.client.LabelId;
import com.google.gerrit.reviewdb.client.PatchSetApproval;
import com.google.gerrit.reviewdb.client.PatchSetApproval.LabelId;
import java.util.ArrayList;
import java.util.Collections;

2
gerrit-common/src/main/java/com/google/gerrit/common/data/LabelTypes.java
View File

@@ -14,7 +14,7 @@
package com.google.gerrit.common.data;
import com.google.gerrit.reviewdb.client.PatchSetApproval.LabelId;
import com.google.gerrit.reviewdb.client.LabelId;
import java.util.ArrayList;
import java.util.Collections;