opendev/gerrit
Code Issues Proposed changes

Convert most NotesMigration#enabled() calls to #readChanges()

Browse Source 
Most of the time this is used to avoid codepaths that shouldn't be
enabled unless *both* NoteDb reads and writes are enabled.

Change-Id: I75958e79e20199f3b19a539bf22b7c3b49a066ee
This commit is contained in:
Dave Borowitz
2016-05-17 15:56:08 -04:00
parent 251443314d
commit a0a85fe7ed
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/AbstractPushForReview.java
View File

@@ -456,8 +456,8 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest {
@Test
public void testPushForMasterWithHashtagsNoteDbDisabled() throws Exception {
// push with hashtags should fail when noteDb is disabled
assume().that(notesMigration.enabled()).isFalse();
// Push with hashtags should fail when reading from NoteDb is disabled.
assume().that(notesMigration.readChanges()).isFalse();
PushOneCommit.Result r = pushTo("refs/for/master%hashtag=tag1");
r.assertErrorStatus("cannot add hashtags; noteDb is disabled");
}