opendev/gerrit
Code Issues Proposed changes

JythonShell: Fix ClassNewInstance warning flagge by error prone

Browse Source 
The following warning is issued on the base version by error prone:

warning: [ClassNewInstance] Class.newInstance() bypasses exception
checking; prefer getConstructor().newInstance()
      shell = console.newInstance();
                                 ^
    (see http://errorprone.info/bugpattern/ClassNewInstance)
  Did you mean 'shell = console.getConstructor().newInstance();'?

Change-Id: Ia3b474422965851ae1f64de4f2767179af33bf12
This commit is contained in:
David Ostrovsky 2017-02-18 12:43:20 +01:00 committed by David Pursehouse
parent 48a05061fc
commit a0cb16567a
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-pgm/src/main/java/com/google/gerrit/pgm/JythonShell.java
View File

@ -78,9 +78,14 @@ public class JythonShell {
new Object[] {null, env});
try {
shell = console.newInstance();
shell = console.getConstructor(new Class[] {}).newInstance();
log.info("Jython shell instance created.");
} catch (InstantiationException | IllegalAccessException e) {
} catch (InstantiationException
| IllegalAccessException
| IllegalArgumentException
| InvocationTargetException
| NoSuchMethodException
| SecurityException e) {
throw noInterpreter(e);
}
injectedVariables = new ArrayList<>();