opendev/gerrit
Code Issues Proposed changes

DefaultChangeReportFormatter: Make constructor and urlFormatter visible

Browse Source 
Implementations may want to only change the default for some of the
ChangeReportFormatter's methods, in which case it makes sense to
extend the default implementation. However this is not possible when
its constructor is private.

Likewise, extending classes might need to use the UrlFormatter instance.

Make the constructor public and the UrlFormatter protected so that they
are visible to deriving classes.

Change-Id: Ia4a24f29e0d283cad40b1f90d019ea7f65bc0cb2
This commit is contained in:
David Pursehouse
2019-08-21 15:34:03 +09:00
parent c65db0ee1d
commit a0fa8af831
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/git/DefaultChangeReportFormatter.java
View File

@@ -28,10 +28,10 @@ public class DefaultChangeReportFormatter implements ChangeReportFormatter {
private static final String SUBJECT_CROP_APPENDIX = "...";
private static final int SUBJECT_CROP_RANGE = 10;
private final DynamicItem<UrlFormatter> urlFormatter;
protected final DynamicItem<UrlFormatter> urlFormatter;
@Inject
DefaultChangeReportFormatter(DynamicItem<UrlFormatter> urlFormatter) {
public DefaultChangeReportFormatter(DynamicItem<UrlFormatter> urlFormatter) {
this.urlFormatter = urlFormatter;
}