opendev/gerrit
Code Issues Proposed changes

Revert "E-mail subject truncation is over-eager"

Browse Source 
This reverts commit b4dae5e1a0

The truncation failed when the subject length was 59,
throwing StringIndexOutOfBoundsException and causing
email formatting to abort with no message sent.
This commit is contained in:
Shawn Pearce
2012-07-16 07:50:02 -07:00
committed by gerrit code review
parent 0d26889a45
commit a19c08ea32
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeSubject.vm
View File

@@ -32,6 +32,6 @@
## subject line for ALL emails related to changes.
##
#macro(elipses $length $str)
#if(($str.length()+3) > $length)${str.substring(0,$length)}...#else$str#end
#if($str.length() > $length)${str.substring(0,$length)}...#else$str#end
#end
Change in $projectName.replaceAll('/.*/', '...')[$branch.shortName]: #elipses(60, $change.subject)