opendev/gerrit
Code Issues Proposed changes

Fix disabled primary/secondary buttons

Browse Source 
Because the disabled and the primary/raised rules have the same
specificity, the disabled definition needs to be defined below so in the
event both conditions are met, it takes precedence.

Bug: Issue 7940
Change-Id: I5ea8e9527ee5fffa3219702f3963853d887bd085
This commit is contained in:
Becky Siegel
2017-12-11 14:59:59 -08:00
parent 7ba85c0c82
commit a1be3e2884
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
polygerrit-ui/app/elements/shared/gr-button/gr-button.html
View File

@@ -57,12 +57,6 @@ limitations under the License.
), var(--background-color); ), var(--background-color);
} }
:host([disabled]) {
--background-color: #eaeaea;
--button-color: #a8a8a8;
cursor: default;
}
/* Styles for raised buttons specifically */ /* Styles for raised buttons specifically */
:host([primary][raised]), :host([primary][raised]),
:host([secondary][raised]) { :host([secondary][raised]) {
@@ -70,6 +64,14 @@ limitations under the License.
--button-color: #fff; --button-color: #fff;
} }
/* Keep below color definition for primary/secondary so that this takes
precedence when disabled. */
:host([disabled]) {
--background-color: #eaeaea;
--button-color: #a8a8a8;
cursor: default;
}
/* Styles for link buttons specifically */ /* Styles for link buttons specifically */
:host([link]) { :host([link]) {
--background-color: transparent; --background-color: transparent;