opendev/gerrit
Code Issues Proposed changes

Merge "Log sign in failures on info level"

Browse Source
This commit is contained in:
Shawn Pearce
2012-06-22 07:18:34 -07:00
committed by gerrit code review
parent a5335cc2c5 0a1e3ed097
commit a1c20703e2
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/UserPassAuthServiceImpl.java
View File

@@ -30,11 +30,17 @@ import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.inject.Inject; import com.google.inject.Inject;
import com.google.inject.Provider; import com.google.inject.Provider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class UserPassAuthServiceImpl implements UserPassAuthService { class UserPassAuthServiceImpl implements UserPassAuthService {
private final Provider<WebSession> webSession; private final Provider<WebSession> webSession;
private final AccountManager accountManager; private final AccountManager accountManager;
private final AuthType authType; private final AuthType authType;
private static final Logger log = LoggerFactory
.getLogger(UserPassAuthServiceImpl.class);
@Inject @Inject
UserPassAuthServiceImpl(final Provider<WebSession> webSession, UserPassAuthServiceImpl(final Provider<WebSession> webSession,
final AccountManager accountManager, final AuthConfig authConfig) { final AccountManager accountManager, final AuthConfig authConfig) {
@@ -73,6 +79,7 @@ class UserPassAuthServiceImpl implements UserPassAuthService {
callback.onSuccess(result); callback.onSuccess(result);
return; return;
} catch (AccountException e) { } catch (AccountException e) {
log.info(String.format("'%s' failed to sign in: %s", username, e.getMessage()));
result.setError(LoginResult.Error.INVALID_LOGIN); result.setError(LoginResult.Error.INVALID_LOGIN);
callback.onSuccess(result); callback.onSuccess(result);
return; return;