opendev/gerrit
Code Issues Proposed changes

Merge "PolyGerrit: Expose error function in plugin rest API"

Browse Source
This commit is contained in:
David Ostrovsky
2018-08-29 20:35:43 +00:00
committed by Gerrit Code Review
parent a9675bab09 a4ac1abec0
commit a208e2791c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-plugin-rest-api.js
View File

@@ -43,10 +43,14 @@
* @param {string} method HTTP Method (GET, POST, etc)
* @param {string} url URL without base path or plugin prefix
* @param {Object=} payload Respected for POST and PUT only.
* @param {?function(?Response, string=)=} opt_errFn
* passed as null sometimes.
* @return {!Promise}
*/
GrPluginRestApi.prototype.fetch = function(method, url, opt_payload) {
return getRestApi().send(method, this.opt_prefix + url, opt_payload);
GrPluginRestApi.prototype.fetch = function(method, url, opt_payload,
opt_errFn) {
return getRestApi().send(method, this.opt_prefix + url, opt_payload,
opt_errFn);
};
/**
@@ -54,10 +58,13 @@
* @param {string} method HTTP Method (GET, POST, etc)
* @param {string} url URL without base path or plugin prefix
* @param {Object=} payload Respected for POST and PUT only.
* @param {?function(?Response, string=)=} opt_errFn
* passed as null sometimes.
* @return {!Promise} resolves on success, rejects on error.
*/
GrPluginRestApi.prototype.send = function(method, url, opt_payload) {
return this.fetch(method, url, opt_payload).then(response => {
GrPluginRestApi.prototype.send = function(method, url, opt_payload,
opt_errFn) {
return this.fetch(method, url, opt_payload, opt_errFn).then(response => {
if (response.status < 200 || response.status >= 300) {
return response.text().then(text => {
if (text) {