opendev/gerrit
Code Issues Proposed changes

Create unit test for index template render

Browse Source 
Bug: Issue 6386
Change-Id: Icc30db9356dd84254720484f84c9fa164d20a523
This commit is contained in:
Wyatt Allen 2017-06-01 13:31:44 -07:00
parent f0232ae277
commit a2155244fc
2 changed files with 22 additions and 1 deletions
gerrit-httpd/src
main/java/com/google/gerrit/httpd/raw
IndexServlet.java
test/java/com/google/gerrit/httpd/raw
IndexServletTest.java

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/IndexServlet.java

@ -34,7 +34,7 @@ import javax.servlet.http.HttpServletResponse;
public class IndexServlet extends HttpServlet { public class IndexServlet extends HttpServlet {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private final byte[] indexSource; protected final byte[] indexSource;
IndexServlet(String canonicalURL, @Nullable String cdnPath) throws URISyntaxException { IndexServlet(String canonicalURL, @Nullable String cdnPath) throws URISyntaxException {
String resourcePath = "com/google/gerrit/httpd/raw/PolyGerritIndexHtml.soy"; String resourcePath = "com/google/gerrit/httpd/raw/PolyGerritIndexHtml.soy";

21
gerrit-httpd/src/test/java/com/google/gerrit/httpd/raw/IndexServletTest.java

@ -21,6 +21,16 @@ import java.net.URISyntaxException;
import org.junit.Test; import org.junit.Test;
public class IndexServletTest { public class IndexServletTest {
class TestIndexServlet extends IndexServlet {
TestIndexServlet(String canonicalURL, String cdnPath) throws URISyntaxException {
super(canonicalURL, cdnPath);
}
String getIndexSource() {
return new String(indexSource);
}
}
@Test @Test
public void noPathAndNoCDN() throws URISyntaxException { public void noPathAndNoCDN() throws URISyntaxException {
SoyMapData data = IndexServlet.getTemplateData("http://example.com/", null); SoyMapData data = IndexServlet.getTemplateData("http://example.com/", null);
@ -52,4 +62,15 @@ public class IndexServletTest {
assertThat(data.getSingle("staticResourcePath").stringValue()) assertThat(data.getSingle("staticResourcePath").stringValue())
.isEqualTo("http://my-cdn.com/foo/bar/"); .isEqualTo("http://my-cdn.com/foo/bar/");
} }
@Test
public void renderTemplate() throws URISyntaxException {
String testCanonicalUrl = "foo-url";
String testCdnPath = "bar-cdn";
TestIndexServlet servlet = new TestIndexServlet(testCanonicalUrl, testCdnPath);
String output = servlet.getIndexSource();
assertThat(output).contains("<!DOCTYPE html>");
assertThat(output).contains("window.CANONICAL_PATH = '" + testCanonicalUrl);
assertThat(output).contains("<link rel=\"preload\" href=\"" + testCdnPath);
}
} }