opendev/gerrit
Code Issues Proposed changes

BatchUpdateListener: Rename method for consistency

Browse Source 
Change-Id: I9cbf70bf852f8da877c84e6791dd9051a262393b
This commit is contained in:
Dave Borowitz
2017-03-13 10:07:32 -04:00
parent b5aea604d6
commit a2661f509a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/SubmitStrategyListener.java
View File

@@ -58,7 +58,7 @@ public class SubmitStrategyListener implements BatchUpdateListener {
} }
@Override @Override
public void afterRefUpdates() throws ResourceConflictException { public void afterUpdateRefs() throws ResourceConflictException {
if (failAfterRefUpdates) { if (failAfterRefUpdates) {
throw new ResourceConflictException("Failing after ref updates"); throw new ResourceConflictException("Failing after ref updates");
} }

4
gerrit-server/src/main/java/com/google/gerrit/server/update/BatchUpdate.java
View File

@@ -334,7 +334,7 @@ public class BatchUpdate implements AutoCloseable {
for (BatchUpdate u : updates) { for (BatchUpdate u : updates) {
u.executeRefUpdates(dryrun); u.executeRefUpdates(dryrun);
} }
listener.afterRefUpdates(); listener.afterUpdateRefs();
for (BatchUpdate u : updates) { for (BatchUpdate u : updates) {
u.reindexChanges(u.executeChangeOps(updateChangesInParallel, dryrun)); u.reindexChanges(u.executeChangeOps(updateChangesInParallel, dryrun));
} }
@@ -352,7 +352,7 @@ public class BatchUpdate implements AutoCloseable {
for (BatchUpdate u : updates) { for (BatchUpdate u : updates) {
u.executeRefUpdates(dryrun); u.executeRefUpdates(dryrun);
} }
listener.afterRefUpdates(); listener.afterUpdateRefs();
break; break;
default: default:
throw new IllegalStateException("invalid execution order: " + order); throw new IllegalStateException("invalid execution order: " + order);

2
gerrit-server/src/main/java/com/google/gerrit/server/update/BatchUpdateListener.java
View File

@@ -27,7 +27,7 @@ public interface BatchUpdateListener {
default void afterUpdateRepos() throws Exception {} default void afterUpdateRepos() throws Exception {}
/** Called after updating all refs. */ /** Called after updating all refs. */
default void afterRefUpdates() throws Exception {} default void afterUpdateRefs() throws Exception {}
/** Called after updating all changes. */ /** Called after updating all changes. */
default void afterUpdateChanges() throws Exception {} default void afterUpdateChanges() throws Exception {}