opendev/gerrit
Code Issues Proposed changes

Revert "Split off library classes from server/patch/ into diff/"

Browse Source 
This reverts commit 0d157b3561.

Reason for revert: full class name goes into H2 keys and values,
and possibly in other data structures in other deployments
(eg. at google), causing cache misses, warnings and/or more
cache dysfunction.

See also https://bugs.chromium.org/p/gerrit/issues/detail?id=7784&desc=2

Change-Id: I03851b8f783b93929e7dc27548fb75882b6bfe05
This commit is contained in:
Han-Wen Nienhuys
2017-11-17 09:21:05 +00:00
parent 6a70aea137
commit a2743969b3
75 changed files with 150 additions and 264 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/CommentsUtil.java
View File

@@ -44,13 +44,13 @@ import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.reviewdb.server.ReviewDbUtil;
import com.google.gerrit.server.config.AllUsersName;
import com.google.gerrit.server.config.GerritServerId;
import com.google.gerrit.server.diff.PatchListCache;
import com.google.gerrit.server.diff.PatchListNotAvailableException;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.notedb.ChangeNotes;
import com.google.gerrit.server.notedb.ChangeUpdate;
import com.google.gerrit.server.notedb.NoteDbChangeState.PrimaryStorage;
import com.google.gerrit.server.notedb.NotesMigration;
import com.google.gerrit.server.patch.PatchListCache;
import com.google.gerrit.server.patch.PatchListNotAvailableException;
import com.google.gerrit.server.update.BatchUpdateReviewDb;
import com.google.gerrit.server.update.ChangeContext;
import com.google.gwtorm.server.OrmException;