opendev/gerrit
Code Issues Proposed changes

Remove superfluous/misleading methods from ChangeEdit

Browse Source 
Some of the methods of ChangeEdit were superfluous or misleading.
For this reason, code calling one of those methods is adjusted to work
without them.

Change-Id: I7a2e094bb6eaf5a5ae98e24f03cd615a3c7d0fff
This commit is contained in:
Alice Kober-Sotzek
2017-03-16 15:07:27 +01:00
parent 30d6c7d3da
commit a28db80825
11 changed files with 36 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-server/src/main/java/com/google/gerrit/server/change/FileInfoJson.java
View File

@@ -48,9 +48,14 @@ public class FileInfoJson {
Map<String, FileInfo> toFileInfoMap(Change change, RevId revision, @Nullable PatchSet base)
throws PatchListNotAvailableException {
ObjectId objectId = ObjectId.fromString(revision.get());
return toFileInfoMap(change, objectId, base);
}
Map<String, FileInfo> toFileInfoMap(Change change, ObjectId objectId, @Nullable PatchSet base)
throws PatchListNotAvailableException {
ObjectId a = (base == null) ? null : ObjectId.fromString(base.getRevision().get());
ObjectId b = ObjectId.fromString(revision.get());
return toFileInfoMap(change, new PatchListKey(a, b, Whitespace.IGNORE_NONE));
return toFileInfoMap(change, new PatchListKey(a, objectId, Whitespace.IGNORE_NONE));
}
Map<String, FileInfo> toFileInfoMap(Change change, RevId revision, int parent)