opendev/gerrit
Code Issues Proposed changes

Changes to diff view for mobile

Browse Source 
- Hide download link and file web links from patchsets.
- Add a full file path.
- Change next/prev buttons to be arrows on either side of full path
- Change subheader to flex/wrap so that the display mode wraps to the
next line instead of the second patch set item.

Bug: Issue 5114
Change-Id: Iefb8afe9d7e2417f8aa2070e52073708c052fa4f
This commit is contained in:
Becky Siegel
2016-12-15 16:14:19 -08:00
parent b148a81817
commit a2ea634774
3 changed files with 76 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
polygerrit-ui/app/elements/diff/gr-patch-range-select/gr-patch-range-select.html
View File

@@ -28,7 +28,15 @@ limitations under the License.
display: inline-block;
}
select {
max-width: 8em;
max-width: 15em;
}
@media screen and (max-width: 50em) {
.filesWeblinks {
display: none;
}
select {
max-width: 5.25em;
}
}
</style>
Patch set:
@@ -45,7 +53,7 @@ limitations under the License.
</template>
</select>
</span>
<span is="dom-if" if="[[filesWeblinks.meta_a]]">
<span is="dom-if" if="[[filesWeblinks.meta_a]]" class="filesWeblinks">
<template is="dom-repeat" items="[[filesWeblinks.meta_a]]" as="weblink">
<a target="_blank"
href$="[[weblink.url]]">[[weblink.name]]</a>
@@ -63,7 +71,7 @@ limitations under the License.
</option>
</template>
</select>
<span is="dom-if" if="[[filesWeblinks.meta_b]]">
<span is="dom-if" if="[[filesWeblinks.meta_b]]" class="filesWeblinks">
<template is="dom-repeat" items="[[filesWeblinks.meta_b]]" as="weblink">
<a target="_blank"
href$="[[weblink.url]]">[[weblink.name]]</a>