opendev/gerrit
Code Issues Proposed changes

Fix double bound exception when loading extensions

Browse Source 
ServerInformation class is already bound, therefore it shouldn't be
bound second time for gerrit extensions.

Change-Id: I0450989836b8752e774bee28a94dbca3e0bcf3fc
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
This commit is contained in:
Dariusz Luksza
2012-10-26 13:00:16 +02:00
parent 6738e5f340
commit a2f91fcedb
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java
View File

@@ -20,7 +20,6 @@ import com.google.gerrit.extensions.annotations.PluginData;
import com.google.gerrit.extensions.annotations.PluginName; import com.google.gerrit.extensions.annotations.PluginName;
import com.google.gerrit.extensions.registration.RegistrationHandle; import com.google.gerrit.extensions.registration.RegistrationHandle;
import com.google.gerrit.extensions.registration.ReloadableRegistrationHandle; import com.google.gerrit.extensions.registration.ReloadableRegistrationHandle;
import com.google.gerrit.extensions.systemstatus.ServerInformation;
import com.google.gerrit.lifecycle.LifecycleManager; import com.google.gerrit.lifecycle.LifecycleManager;
import com.google.inject.AbstractModule; import com.google.inject.AbstractModule;
import com.google.inject.Guice; import com.google.inject.Guice;
@@ -231,13 +230,6 @@ public class Plugin {
modules.add(env.getSysModule()); modules.add(env.getSysModule());
if (apiType == ApiType.PLUGIN) { if (apiType == ApiType.PLUGIN) {
modules.add(env.getSysModule()); modules.add(env.getSysModule());
} else {
modules.add(new AbstractModule() {
@Override
protected void configure() {
bind(ServerInformation.class).toInstance(env.getServerInformation());
}
});
} }
modules.add(new AbstractModule() { modules.add(new AbstractModule() {
@Override @Override