From a310bbc4485b8ce90856232fde3738d2bd4423e9 Mon Sep 17 00:00:00 2001
From: Shawn Pearce <sop@google.com>
Date: Thu, 21 Nov 2013 01:41:38 -0800
Subject: [PATCH] SideBySide2: Draw a line under the file header when
 "fullscreen"

When the Gerrit menus and patch list header have been hidden to show
more of the file contents, draw a line under the tiny header (reviewed
box, path, navigation cluster) to separate it from the displayed file
contents.  This makes it less likely the header is confused with a
line of text, without getting in the way.

Change-Id: Icb5f77c9e67decc3f8e3e2f5e59f7278926b7a08
---
 .../main/java/com/google/gerrit/client/diff/DiffTable.java  | 6 ++++++
 .../java/com/google/gerrit/client/diff/DiffTable.ui.xml     | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java
index f2237c59e4..1e333210f2 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java
@@ -37,6 +37,7 @@ class DiffTable extends Composite {
   private static final Binder uiBinder = GWT.create(Binder.class);
 
   interface DiffTableStyle extends CssResource {
+    String fullscreen();
     String intralineBg();
     String diff();
     String activeLine();
@@ -107,6 +108,11 @@ class DiffTable extends Composite {
     UIObject.setVisible(fileCommentRow, show
         && (fileCommentPanelA.getBoxCount() > 0
             || fileCommentPanelB.getBoxCount() > 0));
+    if (show) {
+      host.header.removeStyleName(style.fullscreen());
+    } else {
+      host.header.addStyleName(style.fullscreen());
+    }
     host.resizeCodeMirror();
   }
 
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml
index bc80bfd7bf..3764cd1840 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml
@@ -23,6 +23,10 @@ limitations under the License.
     @external .cm-keymap-fat-cursor, CodeMirror-cursor;
     @external .cm-searching, .cm-trailingspace, .cm-tab;
 
+    .fullscreen {
+      border-bottom: 1px solid #ddd;
+    }
+
     .difftable { max-width: 1484px; }
     .difftable .CodeMirror-lines { padding: 0; }
     .difftable .CodeMirror pre {