opendev/gerrit
Code Issues Proposed changes

Add hasEmailAddress to IdentifiedUser

Browse Source 
This allows validation code to pass in an email address
for checking, and lets IdentifiedUser worry about how
that occurs.

This refactoring opens the door to delegating the check
to backend systems that are not able to supply the entire
valid email list for a user.

Change-Id: I3db2b34d311d0c8f6f5c0cfdaa109d44fd79e264
This commit is contained in:
Shawn Pearce
2014-12-19 15:36:14 -08:00
parent a1f795a12d
commit a33543d7ea
7 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/account/Emails.java
View File

@@ -66,7 +66,7 @@ public class Emails implements
throw new ResourceNotFoundException();
}
return new AccountResource.Email(rsrc.getUser(), email);
} else if (rsrc.getUser().getEmailAddresses().contains(id.get())) {
} else if (rsrc.getUser().hasEmailAddress(id.get())) {
return new AccountResource.Email(rsrc.getUser(), id.get());
} else {
throw new ResourceNotFoundException();