opendev/gerrit
Code Issues Proposed changes

Extend ChangesRestApiBindingsIT to test creation of edit by editing file

Browse Source 
If a change edit doesn't exist yet, one can create it by editing an
existing file of the change (PUT /changes/<id>/edit/<path>). This call
wasn't covered by the ChangesRestApiBindingsIT#changeEditEndpoints test.

Change-Id: I653e4d282b46273eb5dc8eb26d87a00a56a7eb15
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-07-02 15:15:50 +02:00
parent a80abbea1d
commit a392f805ce
1 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
javatests/com/google/gerrit/acceptance/rest/ChangesRestApiBindingsIT.java
View File

@@ -247,15 +247,24 @@ public class ChangesRestApiBindingsIT extends AbstractRestApiBindingsTest {
private static final ImmutableList<RestCall> CHANGE_MESSAGE_ENDPOINTS = private static final ImmutableList<RestCall> CHANGE_MESSAGE_ENDPOINTS =
ImmutableList.of(RestCall.get("/changes/%s/messages/%s")); ImmutableList.of(RestCall.get("/changes/%s/messages/%s"));
/**
* Change edit REST endpoints that create an edit to be tested, each URL contains placeholders for
* the change identifier and the change edit identifier.
*/
private static final ImmutableList<RestCall> CHANGE_EDIT_CREATE_ENDPOINTS =
ImmutableList.of(
// Create change edit by editing an existing file.
RestCall.put("/changes/%s/edit/%s"),
// Create change edit by deleting an existing file.
RestCall.delete("/changes/%s/edit/%s"));
/** /**
* Change edit REST endpoints to be tested, each URL contains placeholders for the change * Change edit REST endpoints to be tested, each URL contains placeholders for the change
* identifier and the change edit identifier. * identifier and the change edit identifier.
*/ */
private static final ImmutableList<RestCall> CHANGE_EDIT_ENDPOINTS = private static final ImmutableList<RestCall> CHANGE_EDIT_ENDPOINTS =
ImmutableList.of( ImmutableList.of(
// Create change edit by deleting an existing file.
RestCall.delete("/changes/%s/edit/%s"),
// Calls on existing change edit. // Calls on existing change edit.
RestCall.get("/changes/%s/edit/%s"), RestCall.get("/changes/%s/edit/%s"),
RestCall.put("/changes/%s/edit/%s"), RestCall.put("/changes/%s/edit/%s"),
@@ -460,10 +469,21 @@ public class ChangesRestApiBindingsIT extends AbstractRestApiBindingsTest {
} }
@Test @Test
public void changeEditEndpoints() throws Exception { public void changeEditCreateEndpoints() throws Exception {
String changeId = createChange("Subject", FILENAME, "content").getChangeId(); String changeId = createChange("Subject", FILENAME, "content").getChangeId();
// The change edit is created by the first REST call. // Each of the REST calls creates the change edit newly.
execute(
CHANGE_EDIT_CREATE_ENDPOINTS,
() -> adminRestSession.delete("/changes/" + changeId + "/edit"),
changeId,
FILENAME);
}
@Test
public void changeEditEndpoints() throws Exception {
String changeId = createChange("Subject", FILENAME, "content").getChangeId();
gApi.changes().id(changeId).edit().create();
execute(CHANGE_EDIT_ENDPOINTS, changeId, FILENAME); execute(CHANGE_EDIT_ENDPOINTS, changeId, FILENAME);
} }