opendev/gerrit
Code Issues Proposed changes

TestSubmitRule: Enable logErrors when debug logging is enabled

Browse Source 
Change-Id: I3741158ada2dcc8bd3988535e3db70b0651e8936
This commit is contained in:
David Pursehouse
2020-06-18 13:54:28 +09:00
parent 4d7f99154a
commit a414e5b82d
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/com/google/gerrit/server/restapi/change/TestSubmitRule.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.server.restapi.change;
import com.google.common.base.MoreObjects; import com.google.common.base.MoreObjects;
import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.common.data.SubmitRecord; import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.extensions.common.AccountInfo; import com.google.gerrit.extensions.common.AccountInfo;
import com.google.gerrit.extensions.common.TestSubmitRuleInfo; import com.google.gerrit.extensions.common.TestSubmitRuleInfo;
@@ -44,6 +45,8 @@ import java.util.List;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
public class TestSubmitRule implements RestModifyView<RevisionResource, TestSubmitRuleInput> { public class TestSubmitRule implements RestModifyView<RevisionResource, TestSubmitRuleInput> {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
private final Provider<ReviewDb> db; private final Provider<ReviewDb> db;
private final ChangeData.Factory changeDataFactory; private final ChangeData.Factory changeDataFactory;
private final RulesCache rules; private final RulesCache rules;
@@ -88,7 +91,7 @@ public class TestSubmitRule implements RestModifyView<RevisionResource, TestSubm
SubmitRuleOptions.builder() SubmitRuleOptions.builder()
.skipFilters(input.filters == Filters.SKIP) .skipFilters(input.filters == Filters.SKIP)
.rule(input.rule) .rule(input.rule)
.logErrors(false) .logErrors(logger.atFine().isEnabled())
.build(); .build();
ProjectState projectState = projectCache.get(rsrc.getProject()); ProjectState projectState = projectCache.get(rsrc.getProject());