opendev/gerrit
Code Issues Proposed changes

Fix undesired normalization of internal structure

Browse Source 
It's undesired because it is used in other places to check if a comment
is in the same place.

Change-Id: Ic674acd307dedc1573aae61decaefec2f2b4234b
This commit is contained in:
Ole Rehmsen
2018-11-19 16:12:53 +01:00
parent ba0639b379
commit a4641825be
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/diff/gr-ranged-comment-layer/gr-ranged-comment-layer.js
View File

@@ -167,6 +167,9 @@
const ranges = this.get(['_rangesMap', side, lineNum]) || []; const ranges = this.get(['_rangesMap', side, lineNum]) || [];
return ranges return ranges
.map(range => { .map(range => {
// Make a copy, so that the normalization below does not mess with
// our map.
range = Object.assign({}, range);
range.end = range.end === -1 ? line.text.length : range.end; range.end = range.end === -1 ? line.text.length : range.end;
// Normalize invalid ranges where the start is after the end but the // Normalize invalid ranges where the start is after the end but the