opendev/gerrit
Code Issues Proposed changes

Rest API, add GET /past_assigness endpoint for historical assignees

Browse Source 
Returns a set of AccountInfos, ordered by _account_id,  describing every user
ever assigned to a change.

Change-Id: Ibc789a33d5f93937a76e5c091e1405b4be1119b5
This commit is contained in:
Sven Selberg
2016-09-21 15:14:38 +02:00
parent bed1f41ac9
commit a4e316571d
2 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
gerrit-server/src/main/java/com/google/gerrit/server/change/GetPastAssignees.java Normal file
View File

@@ -0,0 +1,53 @@
// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.change;
import com.google.gerrit.extensions.common.AccountInfo;
import com.google.gerrit.extensions.restapi.Response;
import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.server.account.AccountInfoCacheFactory;
import com.google.gerrit.server.account.AccountJson;
import com.google.inject.Inject;
import java.util.Collections;
import java.util.Set;
import static java.util.stream.Collectors.toSet;
public class GetPastAssignees implements RestReadView<ChangeResource> {
private final AccountInfoCacheFactory.Factory accountInfos;
@Inject
GetPastAssignees(AccountInfoCacheFactory.Factory accountInfosFactory) {
this.accountInfos = accountInfosFactory;
}
@Override
public Response<Set<AccountInfo>> apply(ChangeResource rsrc)
throws Exception {
Set<Account.Id> pastAssignees =
rsrc.getControl().getNotes().load().getPastAssignees();
if (pastAssignees == null) {
return Response.ok(Collections.emptySet());
}
AccountInfoCacheFactory accountInfoFactory = accountInfos.create();
return Response.ok(pastAssignees.stream()
.map(accountInfoFactory::get)
.map(AccountJson::toAccountInfo)
.collect(toSet()));
}
}

1
gerrit-server/src/main/java/com/google/gerrit/server/change/Module.java
View File

@@ -54,6 +54,7 @@ public class Module extends RestApiModule {
get(CHANGE_KIND, "topic").to(GetTopic.class);
get(CHANGE_KIND, "in").to(IncludedIn.class);
get(CHANGE_KIND, "assignee").to(GetAssignee.class);
get(CHANGE_KIND, "past_assignees").to(GetPastAssignees.class);
put(CHANGE_KIND, "assignee").to(PutAssignee.class);
delete(CHANGE_KIND, "assignee").to(DeleteAssignee.class);
get(CHANGE_KIND, "hashtags").to(GetHashtags.class);