opendev/gerrit
Code Issues Proposed changes

Merge "Add tests for the number of emails sent upon adding reviewers"

Browse Source
This commit is contained in:
David Pursehouse
2017-04-18 13:49:16 +00:00
committed by Gerrit Code Review
parent fea441b8a1 f01f12a165
commit a505cf0a9d
1 changed files with 44 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/ChangeReviewersByEmailIT.java
View File

@@ -222,6 +222,50 @@ public class ChangeReviewersByEmailIT extends AbstractDaemonTest {
}
}
@Test
public void reviewerAndCCReceiveSameEmail() throws Exception {
assume().that(notesMigration.readChanges()).isTrue();
PushOneCommit.Result r = createChange();
for (ReviewerState state : ImmutableList.of(ReviewerState.CC, ReviewerState.REVIEWER)) {
for (int i = 0; i < 10; i++) {
AddReviewerInput input = new AddReviewerInput();
input.reviewer = String.format("%s-%s@gerritcodereview.com", state, i);
input.state = state;
gApi.changes().id(r.getChangeId()).addReviewer(input);
}
}
// Also add user as a regular reviewer
AddReviewerInput input = new AddReviewerInput();
input.reviewer = user.email;
input.state = ReviewerState.REVIEWER;
gApi.changes().id(r.getChangeId()).addReviewer(input);
sender.clear();
gApi.changes().id(r.getChangeId()).revision(r.getCommit().name()).review(ReviewInput.approve());
// Assert that only one email was sent out to everyone
assertThat(sender.getMessages()).hasSize(1);
}
@Test
public void addingMultipleReviewersAndCCsAtOnceSendsOnlyOneEmail() throws Exception {
assume().that(notesMigration.readChanges()).isTrue();
PushOneCommit.Result r = createChange();
ReviewInput reviewInput = new ReviewInput();
for (ReviewerState state : ImmutableList.of(ReviewerState.CC, ReviewerState.REVIEWER)) {
for (int i = 0; i < 10; i++) {
reviewInput.reviewer(String.format("%s-%s@gerritcodereview.com", state, i), state, true);
}
}
assertThat(reviewInput.reviewers).hasSize(20);
sender.clear();
gApi.changes().id(r.getChangeId()).revision(r.getCommit().name()).review(reviewInput);
assertThat(sender.getMessages()).hasSize(1);
}
@Test
public void rejectMissingEmail() throws Exception {
assume().that(notesMigration.readChanges()).isTrue();