From a564df698a63ac0f5eb6d40c9ea39767745497be Mon Sep 17 00:00:00 2001
From: David Pursehouse <dpursehouse@collab.net>
Date: Wed, 12 Sep 2018 14:46:10 +0900
Subject: [PATCH] Make inner classes static where possible

Change-Id: Icb75d765bd4e9198ef294c3d099c762a395a623e
---
 .../test/java/com/google/gerrit/httpd/raw/IndexServletTest.java | 2 +-
 .../java/com/google/gerrit/pgm/http/jetty/ProjectQoSFilter.java | 2 +-
 .../java/com/google/gerrit/server/project/RefControlTest.java   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gerrit-httpd/src/test/java/com/google/gerrit/httpd/raw/IndexServletTest.java b/gerrit-httpd/src/test/java/com/google/gerrit/httpd/raw/IndexServletTest.java
index 4a5bdc1aec..abf890e675 100644
--- a/gerrit-httpd/src/test/java/com/google/gerrit/httpd/raw/IndexServletTest.java
+++ b/gerrit-httpd/src/test/java/com/google/gerrit/httpd/raw/IndexServletTest.java
@@ -22,7 +22,7 @@ import java.net.URISyntaxException;
 import org.junit.Test;
 
 public class IndexServletTest {
-  class TestIndexServlet extends IndexServlet {
+  static class TestIndexServlet extends IndexServlet {
     private static final long serialVersionUID = 1L;
 
     TestIndexServlet(String canonicalURL, String cdnPath) throws URISyntaxException {
diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/ProjectQoSFilter.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/ProjectQoSFilter.java
index f85a27a379..4d2bb4168e 100644
--- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/ProjectQoSFilter.java
+++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/ProjectQoSFilter.java
@@ -147,7 +147,7 @@ public class ProjectQoSFilter implements Filter {
   @Override
   public void destroy() {}
 
-  private final class Listener implements ContinuationListener {
+  private static final class Listener implements ContinuationListener {
     final Future<?> future;
 
     Listener(Future<?> future) {
diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
index df4cb9559b..1fc95c18bc 100644
--- a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
+++ b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
@@ -895,7 +895,7 @@ public class RefControlTest {
     return all.get(local.getProject().getNameKey());
   }
 
-  private class MockUser extends CurrentUser {
+  private static class MockUser extends CurrentUser {
     private final String username;
     private final GroupMembership groups;