opendev/gerrit
Code Issues Proposed changes

Use try/finally to ensure oldValue is cleared

Browse Source 
If any JS exception is thrown during event delivery the oldValue
should still be set to null to enable garbage collection.

Change-Id: I740db06e93162f86982ffd418c2072bfb4d5d75c
This commit is contained in:
Shawn Pearce
2013-04-26 10:39:05 -07:00
parent 7b05719b66
commit a5ec9845f6
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ListenableOldValue.java
View File

@@ -23,8 +23,11 @@ public class ListenableOldValue<T> extends ListenableValue<T> {
} }
public void set(final T value) { public void set(final T value) {
oldValue = get(); try {
super.set(value); oldValue = get();
oldValue = null; // allow it to be gced before the next event super.set(value);
} finally {
oldValue = null; // allow it to be gced before the next event
}
} }
} }