opendev/gerrit
Code Issues Proposed changes

gr-download-dialog.js: Use strict equality comparison

Browse Source 
Change-Id: I35aea0f253aa9f440a482026ad793c0152e36ba0
This commit is contained in:
David Ostrovsky
2017-05-09 08:17:13 +02:00
parent 1c899dec74
commit a61d7594cc
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js
View File

@@ -79,7 +79,7 @@
_computeDownloadCommands: function(change, patchNum, _selectedScheme) { _computeDownloadCommands: function(change, patchNum, _selectedScheme) {
var commandObj; var commandObj;
for (var rev in change.revisions) { for (var rev in change.revisions) {
if (change.revisions[rev]._number == patchNum && if (change.revisions[rev]._number === patchNum &&
change.revisions[rev].fetch.hasOwnProperty(_selectedScheme)) { change.revisions[rev].fetch.hasOwnProperty(_selectedScheme)) {
commandObj = change.revisions[rev].fetch[_selectedScheme].commands; commandObj = change.revisions[rev].fetch[_selectedScheme].commands;
break; break;
@@ -111,7 +111,7 @@
_computeDownloadFilename: function(change, patchNum, zip) { _computeDownloadFilename: function(change, patchNum, zip) {
var shortRev; var shortRev;
for (var rev in change.revisions) { for (var rev in change.revisions) {
if (change.revisions[rev]._number == patchNum) { if (change.revisions[rev]._number === patchNum) {
shortRev = rev.substr(0, 7); shortRev = rev.substr(0, 7);
break; break;
} }
@@ -126,7 +126,7 @@
_computeSchemes: function(change, patchNum) { _computeSchemes: function(change, patchNum) {
for (var rev in change.revisions) { for (var rev in change.revisions) {
if (change.revisions[rev]._number == patchNum) { if (change.revisions[rev]._number === patchNum) {
var fetch = change.revisions[rev].fetch; var fetch = change.revisions[rev].fetch;
if (fetch) { if (fetch) {
return Object.keys(fetch).sort(); return Object.keys(fetch).sort();
@@ -143,7 +143,7 @@
}, },
_computeSchemeSelected: function(scheme, selectedScheme) { _computeSchemeSelected: function(scheme, selectedScheme) {
return scheme == selectedScheme; return scheme === selectedScheme;
}, },
_handleSchemeTap: function(e) { _handleSchemeTap: function(e) {
@@ -166,8 +166,8 @@
}, },
_schemesChanged: function(schemes) { _schemesChanged: function(schemes) {
if (schemes.length == 0) { return; } if (schemes.length === 0) { return; }
if (schemes.indexOf(this._selectedScheme) == -1) { if (schemes.indexOf(this._selectedScheme) === -1) {
this._selectedScheme = schemes.sort()[0]; this._selectedScheme = schemes.sort()[0];
} }
}, },