opendev/gerrit
Code Issues Proposed changes

Fix: SSH abandon or restore adds the cover message twice

Browse Source 
When a change is abandoned or restored over SSH, and a cover message
is included with the --message option, the message is added on the
review twice.  First it is added with the review comment:

  Patch Set 1:
  Message

And then again with the abandon/restore comment:

  Abandoned/Restored
  Message

The review comment is added regardless of whether or not any review
labels have been applied at the same time.

Fix it so that the message is only added once.  If review labels are
applied, the message will be added with the regular review comment:

  Patch Set 1:
  Message

And then the abandon/restore comment will be added without any message:

  Abandoned/Restored

If there are no review labels applied, there will be no review comment,
and the message will be added with the abandon/restore comment:

  Abandoned/Restored
  Message

Bug: Issue 1721
Change-Id: I9c7e81599854a5d12656e41a29341e2938620a00
This commit is contained in:
David Pursehouse
2012-12-13 19:28:34 +09:00
parent c13a2fd057
commit a65b695ee5
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
View File

@@ -195,9 +195,11 @@ public class ReviewCommand extends SshCommand {
private void applyReview(final ChangeControl ctl, final PatchSet.Id patchSetId,
final PostReview.Input review) throws Exception {
reviewProvider.get().apply(new RevisionResource(
new ChangeResource(ctl),
db.patchSets().get(patchSetId)), review);
if (!review.labels.isEmpty()) {
reviewProvider.get().apply(new RevisionResource(
new ChangeResource(ctl),
db.patchSets().get(patchSetId)), review);
}
}
private void approveOne(final PatchSet.Id patchSetId) throws Exception {
@@ -218,6 +220,13 @@ public class ReviewCommand extends SshCommand {
}
}
// If review labels are being applied, the comment will be included
// on the review note. We don't need to add it again on the abandon
// or restore comment.
if (!review.labels.isEmpty()) {
changeComment = null;
}
try {
ChangeControl ctl =
changeControlFactory.controlFor(patchSetId.getParentKey());