opendev/gerrit
Code Issues Proposed changes

Don't fail tests when symlinks are found

Browse Source 
Buck runs tests in temporary directories and can clean up the test
output on its own.  Don't complain and fail a test if a symlink is
discovered in the path, instead rely on Buck to cleanup later.

Change-Id: If450191abc7d0fd378d684e16656623f4b59ea7e
This commit is contained in:
Shawn Pearce 2013-07-26 16:44:17 -07:00
parent 99854df8c5
commit a7bad77a08
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/TempFileUtil.java
View File

@ -29,7 +29,7 @@ public class TempFileUtil {
public static void recursivelyDelete(File dir) throws IOException {
if (!dir.getPath().equals(dir.getCanonicalPath())) {
// Directory symlink reaching outside of temporary space.
throw new IOException("Refusing to clear symlink " + dir.getPath());
return;
}
File[] contents = dir.listFiles();
if (contents != null) {