opendev/gerrit
Code Issues Proposed changes

Don't compute mergeability for abandoned changes.

Browse Source 
The Ia798667901fe8d734ca29bcf81c7b9b4a1eb4c50 introduced the feature
of abandoning inactive changes. One of the main reasons was to avoid
expensive (re)computation of the mergeability flag when the target
branch gets updated.

However, offline reindexing continued to compute the mergeability flag
for abandoned changes too.

Returning null from ChangeData.isMerged for abandoned changes makes
sure that this flag is not computed for abandoned changes.

Documentation is updated to make it clear that is:mergeable operator
doesn't support abandoned changes.

Change-Id: Iaae8b18bb22865fe3116dc62f05b82199fd32832
This commit is contained in:
Saša Živkov
2017-03-21 17:37:29 +01:00
parent 73f7323839
commit a803593675
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/user-search.txt
View File

@@ -350,6 +350,9 @@ is:mergeable::
+
True if the change has no merge conflicts and could be merged into its
destination branch.
+
Mergeability of abandoned changes is not computed. This operator will
not find any abandoned but mergeable changes.
[[status]]
status:open, status:pending::