opendev/gerrit
Code Issues Proposed changes

Fix resource leak in MarkdownFormatter

Browse Source 
Change-Id: I156a763291259799ab7fc7c373e80c3fa61b375e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-10-18 13:51:37 +02:00
parent 4cef11a77d
commit a858d8c89e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/documentation/MarkdownFormatter.java
View File

@@ -136,8 +136,12 @@ public class MarkdownFormatter {
InputStream in = url.openStream(); InputStream in = url.openStream();
try { try {
TemporaryBuffer.Heap tmp = new TemporaryBuffer.Heap(128 * 1024); TemporaryBuffer.Heap tmp = new TemporaryBuffer.Heap(128 * 1024);
tmp.copy(in); try {
return new String(tmp.toByteArray(), "UTF-8"); tmp.copy(in);
return new String(tmp.toByteArray(), "UTF-8");
} finally {
tmp.close();
}
} finally { } finally {
in.close(); in.close();
} }