opendev/gerrit
Code Issues Proposed changes

Merge "Fix firefox value binding in gr-select with dom-repeat" into stable-2.15

Browse Source
This commit is contained in:
Becky Siegel
2017-11-15 00:16:56 +00:00
committed by Gerrit Code Review
parent b151b04d5c 811adcbc30
commit a887889b92
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/shared/gr-select/gr-select.js
View File

@@ -35,7 +35,14 @@
_updateValue() { _updateValue() {
if (this.bindValue) { if (this.bindValue) {
// Set for chrome/safari so it happens instantly
this.nativeSelect.value = this.bindValue; this.nativeSelect.value = this.bindValue;
// Async needed for firefox to populate value. It was trying to do it
// before options from a dom-repeat were rendered previously.
// See https://bugs.chromium.org/p/gerrit/issues/detail?id=7735
this.async(() => {
this.nativeSelect.value = this.bindValue;
}, 1);
} }
}, },