From a96173b0368da564cba841a90fee1c8fbdea1cfa Mon Sep 17 00:00:00 2001
From: Tao Zhou <taoalpha@google.com>
Date: Fri, 15 May 2020 16:12:29 +0200
Subject: [PATCH] Don't render gr-thread-list or gr-comment-list when collapsed
 initially

This will prevent rendering them at initial collapsed state,
with some limitation from polymer:

When if becomes falsy, the stamped content is hidden
but not removed from dom. When if subsequently becomes
truthy again, the content is simply re-shown.

https: //polymer-library.polymer-project.org/3.0/api/elements/dom-if
Change-Id: I7d16f41dae7ba5f5c4b79aff8f0c4f6a7909df32
---
 .../change/gr-message/gr-message_html.js      | 42 ++++++++++---------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message_html.js b/polygerrit-ui/app/elements/change/gr-message/gr-message_html.js
index df142fa72a..99abad2e61 100644
--- a/polygerrit-ui/app/elements/change/gr-message/gr-message_html.js
+++ b/polygerrit-ui/app/elements/change/gr-message/gr-message_html.js
@@ -245,26 +245,28 @@ export const htmlTemplate = html`
               </gr-button>
             </div>
           </template>
-          <template is="dom-if" if="[[!_isCleanerLogExperimentEnabled]]">
-            <gr-comment-list
-              comments="[[comments]]"
-              change-num="[[changeNum]]"
-              patch-num="[[message._revision_number]]"
-              project-name="[[projectName]]"
-              project-config="[[_projectConfig]]"
-            ></gr-comment-list>
-          </template>
-          <template is="dom-if" if="[[_isCleanerLogExperimentEnabled]]">
-            <gr-thread-list
-              change="[[change]]"
-              hidden$="[[!commentThreads.length]]"
-              threads="[[commentThreads]]"
-              change-num="[[changeNum]]"
-              logged-in="[[_loggedIn]]"
-              hide-toggle-buttons
-              on-thread-list-modified="_onThreadListModified"
-            >
-            </gr-thread-list>
+          <template is="dom-if" if="[[_expanded]]">
+            <template is="dom-if" if="[[!_isCleanerLogExperimentEnabled]]">
+              <gr-comment-list
+                comments="[[comments]]"
+                change-num="[[changeNum]]"
+                patch-num="[[message._revision_number]]"
+                project-name="[[projectName]]"
+                project-config="[[_projectConfig]]"
+              ></gr-comment-list>
+            </template>
+            <template is="dom-if" if="[[_isCleanerLogExperimentEnabled]]">
+              <gr-thread-list
+                change="[[change]]"
+                hidden$="[[!commentThreads.length]]"
+                threads="[[commentThreads]]"
+                change-num="[[changeNum]]"
+                logged-in="[[_loggedIn]]"
+                hide-toggle-buttons
+                on-thread-list-modified="_onThreadListModified"
+              >
+              </gr-thread-list>
+            </template>
           </template>
         </div>
       </template>