opendev/gerrit
Code Issues Proposed changes

Fix Show Inherited Rights behavior on refrights table reload

Browse Source 
Make the "Show Inherited Rights" checkbox mechanism on the
project access screen, cause inherited rights to also be
hidden when a refright is added and the refrights table is
reloaded.

Change-Id: I4691750ffce4616b53bb57e3a06857d294dde972
This commit is contained in:
Martin Fick
2011-04-14 15:48:18 -06:00
parent 624f447d4c
commit a9d1575535
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessScreen.java
View File

@@ -53,6 +53,7 @@ public class ProjectAccessScreen extends ProjectScreen {
private RightsTable rights;
private Button delRight;
private AccessRightEditor rightEditor;
private CheckBox showInherited;
public ProjectAccessScreen(final Project.NameKey toShow) {
super(toShow);
@@ -85,18 +86,18 @@ public class ProjectAccessScreen extends ProjectScreen {
private void initParent() {
parentName = new Hyperlink("", "");
final CheckBox show = new CheckBox();
show.setChecked(true);
show.addClickHandler(new ClickHandler() {
showInherited = new CheckBox();
showInherited.setChecked(true);
showInherited.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) {
rights.showInherited(show.isChecked());
rights.showInherited(showInherited.isChecked());
}
});
Grid g = new Grid(2, 3);
g.setWidget(0, 0, new SmallHeading(Util.C.headingParentProjectName()));
g.setWidget(1, 0, parentName);
g.setWidget(1, 1, show);
g.setWidget(1, 1, showInherited);
g.setText(1, 2, Util.C.headingShowInherited());
parentPanel = new VerticalPanel();
@@ -214,6 +215,9 @@ public class ProjectAccessScreen extends ProjectScreen {
for (final InheritedRefRight r : refRights) {
final int row = table.getRowCount();
table.insertRow(row);
if (! showInherited.isChecked() && r.isInherited()) {
table.getRowFormatter().setVisible(row, false);
}
applyDataRowStyle(row);
populate(row, r);
}