opendev/gerrit
Code Issues Proposed changes

Trim leading slash from redirect after oauth login

Browse Source 
Bug: Issue 6059
Change-Id: I35899fa0c76263a4b732c08b4781752c5aca8f4c
This commit is contained in:
Logan Hanks
2017-04-24 17:59:16 +02:00
committed by David Pursehouse
parent b95cafed36
commit aa0baaecb4
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-oauth/src/main/java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java
View File

@@ -16,6 +16,7 @@ package com.google.gerrit.httpd.auth.oauth;
import static javax.servlet.http.HttpServletResponse.SC_UNAUTHORIZED; import static javax.servlet.http.HttpServletResponse.SC_UNAUTHORIZED;
import com.google.common.base.CharMatcher;
import com.google.common.base.Strings; import com.google.common.base.Strings;
import com.google.gerrit.extensions.auth.oauth.OAuthServiceProvider; import com.google.gerrit.extensions.auth.oauth.OAuthServiceProvider;
import com.google.gerrit.extensions.auth.oauth.OAuthToken; import com.google.gerrit.extensions.auth.oauth.OAuthToken;
@@ -154,8 +155,9 @@ class OAuthSession {
webSession.get().login(arsp, true); webSession.get().login(arsp, true);
String suffix = redirectToken.substring(OAuthWebFilter.GERRIT_LOGIN.length() + 1); String suffix = redirectToken.substring(OAuthWebFilter.GERRIT_LOGIN.length() + 1);
suffix = CharMatcher.anyOf("/").trimLeadingFrom(Url.decode(suffix));
StringBuilder rdr = new StringBuilder(urlProvider.get(req)); StringBuilder rdr = new StringBuilder(urlProvider.get(req));
rdr.append(Url.decode(suffix)); rdr.append(suffix);
rsp.sendRedirect(rdr.toString()); rsp.sendRedirect(rdr.toString());
} }