opendev/gerrit
Code Issues Proposed changes

Revert "Additional log on plug-in self-registration and failures."

Browse Source 
This reverts commit c0732b1301


The commit broke server startup with:

java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
        at com.google.gerrit.extensions.registration.DynamicSet.<clinit>(DynamicSet.java:45)
        at com.google.gerrit.server.config.GerritGlobalModule.configure(GerritGlobalModule.java:146
This commit is contained in:
Martin Fick
2012-07-10 17:35:27 -07:00
committed by gerrit code review
parent c0732b1301
commit aa511c0061
3 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/plugins/AutoRegisterModules.java
View File

@@ -192,12 +192,10 @@ class AutoRegisterModules {
if (is("org.apache.sshd.server.Command", clazz)) {
if (sshGen != null) {
PluginLoader.log.info("Exporting " + clazz + " as SSH Command");
sshGen.export(export, clazz);
}
} else if (is("javax.servlet.http.HttpServlet", clazz)) {
if (httpGen != null) {
PluginLoader.log.info("Exporting " + clazz + " as HTTP Servlet");
httpGen.export(export, clazz);
listen(clazz, clazz);
}
@@ -249,7 +247,6 @@ class AutoRegisterModules {
TypeLiteral<?> tl = TypeLiteral.get(type);
if (env.hasDynamicSet(tl)) {
sysSingletons.add(clazz);
PluginLoader.log.info("Registering " + clazz + " to listener " + tl);
sysListen.put(tl, clazz);
} else if (env.hasDynamicMap(tl)) {
if (clazz.getAnnotation(Export.class) == null) {
@@ -258,7 +255,6 @@ class AutoRegisterModules {
clazz.getName(), rawType.getName()));
}
sysSingletons.add(clazz);
PluginLoader.log.info("Registering " + clazz + " to listener " + tl);
sysListen.put(tl, clazz);
} else {
throw new InvalidPluginException(String.format(