opendev/gerrit
Code Issues Proposed changes

AbstractQueryChangesTest: Add test coverage for query: predicate

Browse Source 
Bug: Issue 8604
Change-Id: I197a0e40b9622eb49cad7c8b3be1db3f3d50fa28
This commit is contained in:
David Pursehouse
2018-04-17 09:38:46 +02:00
parent 603c45636e
commit aaa40aa1b8
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
View File

@@ -2144,9 +2144,31 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
@Test @Test
public void userQuery() throws Exception { public void userQuery() throws Exception {
TestRepository<Repo> repo = createProject("repo"); TestRepository<Repo> repo = createProject("repo");
insert(repo, newChange(repo)); Change change1 = insert(repo, newChange(repo));
Change change2 = insert(repo, newChangeForBranch(repo, "stable"));
String queries =
"query1\tproject:repo\n"
+ "query2\tproject:repo status:open\n"
+ "query3\tproject:repo branch:stable\n"
+ "query4\tproject:repo branch:other";
TestRepository<Repo> allUsers = new TestRepository<>(repoManager.openRepository(allUsersName));
String refsUsers = RefNames.refsUsers(userId);
allUsers.branch(refsUsers).commit().add("queries", queries).create();
Ref userRef = allUsers.getRepository().exactRef(refsUsers);
assertThat(userRef).isNotNull();
assertThatQueryException("query:foo").hasMessageThat().isEqualTo("Unknown named query: foo"); assertThatQueryException("query:foo").hasMessageThat().isEqualTo("Unknown named query: foo");
assertQuery("query:query1", change2, change1);
assertQuery("query:query2", change2, change1);
gApi.changes().id(change1.getChangeId()).revision("current").review(ReviewInput.approve());
gApi.changes().id(change1.getChangeId()).revision("current").submit();
assertQuery("query:query2", change2);
assertQuery("query:query3", change2);
assertQuery("query:query4");
} }
protected ChangeInserter newChange(TestRepository<Repo> repo) throws Exception { protected ChangeInserter newChange(TestRepository<Repo> repo) throws Exception {