Add direct members and directly included groups to GroupInfo
When listing groups it is now possible to request that the direct group members and the directly included groups are included into the returned GroupInfos. This is done by setting the options 'o=MEMBERS' and 'o=INCLUDES'. In addition there is a new REST endpoint '/groups/<group-id>/detail' by which a group with its direct members and directly included groups can be retrieved. This new endpoint is used to retrieve the group for populating the AccountGroupMembersScreen. By this 2 requests are saved which would otherwise be needed to fetch the direct group members and the directly included groups. Change-Id: Ib94e5c01cc0880aa508f703f4156ac7fe627d742 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
		| @@ -16,12 +16,14 @@ package com.google.gerrit.server.account; | ||||
|  | ||||
| import com.google.common.collect.Lists; | ||||
| import com.google.gerrit.common.errors.NoSuchGroupException; | ||||
| import com.google.gerrit.extensions.restapi.ResourceNotFoundException; | ||||
| import com.google.gerrit.extensions.restapi.RestReadView; | ||||
| import com.google.gerrit.reviewdb.client.Account; | ||||
| import com.google.gerrit.reviewdb.client.AccountGroup; | ||||
| import com.google.gerrit.server.IdentifiedUser; | ||||
| import com.google.gerrit.server.group.GroupJson; | ||||
| import com.google.gerrit.server.group.GroupJson.GroupInfo; | ||||
| import com.google.gwtorm.server.OrmException; | ||||
| import com.google.inject.Inject; | ||||
|  | ||||
| import java.util.List; | ||||
| @@ -37,7 +39,8 @@ public class GetGroups implements RestReadView<AccountResource> { | ||||
|   } | ||||
|  | ||||
|   @Override | ||||
|   public List<GroupInfo> apply(AccountResource resource) { | ||||
|   public List<GroupInfo> apply(AccountResource resource) | ||||
|       throws ResourceNotFoundException, OrmException { | ||||
|     IdentifiedUser user = resource.getUser(); | ||||
|     Account.Id userId = user.getAccountId(); | ||||
|     List<GroupInfo> groups = Lists.newArrayList(); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Edwin Kempin
					Edwin Kempin