opendev/gerrit
Code Issues Proposed changes

Don't import Id/Key/NameKey directly

Browse Source 
Found all instances matching this regular expression:

  ^import.*\.(?<!gwtorm\.client\.|inject\.)(Id|Key|NameKey);$

There is one remaining import, WebSessionManager.Key, which has a
corresponding Val and is not a gwtorm entity, so I left that one.

Change-Id: I816829a0e1f16b18ba6c4c731b3c444db0590e50
This commit is contained in:
Dave Borowitz
2014-09-11 10:01:31 +02:00
parent 579447e8b0
commit ac235a0126
7 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java
View File

@@ -18,7 +18,6 @@ import com.google.common.util.concurrent.Atomics;
import com.google.gerrit.common.Nullable;
import com.google.gerrit.extensions.annotations.PluginName;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.Project.NameKey;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.RequestCleanup;
@@ -475,7 +474,7 @@ public abstract class BaseCommand implements Command {
}
@Override
public NameKey getProjectNameKey() {
public Project.NameKey getProjectNameKey() {
return projectName;
}