opendev/gerrit
Code Issues Proposed changes

Rename PluginConfigProvider to PluginConfigFactory.

Browse Source 
The PluginConfigProvider was not a guice Provider. Since all classes
named like ...Provider do implement the Provider<T> interface from
guice, we can consider the naming of PluginConfigProvider as
inconsistent.

Change-Id: I83cbe47112865e293a7928b123d94d4b4a3839db
This commit is contained in:
Sasa Zivkov
2013-09-20 14:05:15 +02:00
parent f7bfff88a2
commit acdf533ca7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/dev-plugins.txt
View File

@@ -331,14 +331,14 @@ only use the `plugin` subsection with their own name. For example the
language = Latin language = Latin
---- ----
Via the `com.google.gerrit.server.config.PluginConfigProvider` class a Via the `com.google.gerrit.server.config.PluginConfigFactory` class a
plugin can easily access its configuration and there is no need for a plugin can easily access its configuration and there is no need for a
plugin to parse the `gerrit.config` file on its own: plugin to parse the `gerrit.config` file on its own:
[source,java] [source,java]
---- ----
@Inject @Inject
private com.google.gerrit.server.config.PluginConfigProvider cfg; private com.google.gerrit.server.config.PluginConfigFactory cfg;
... ...

4
gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigProvider.java → gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigFactory.java
View File

@@ -20,11 +20,11 @@ import com.google.inject.Singleton;
import org.eclipse.jgit.lib.Config; import org.eclipse.jgit.lib.Config;
@Singleton @Singleton
public class PluginConfigProvider { public class PluginConfigFactory {
private final Config cfg; private final Config cfg;
@Inject @Inject
PluginConfigProvider(@GerritServerConfig Config cfg) { PluginConfigFactory(@GerritServerConfig Config cfg) {
this.cfg = cfg; this.cfg = cfg;
} }