Console log and reporting on invalid comment ranges
Change-Id: Ie1f0172cee1d7b4a2e78d5eb8c60745162f650f1
This commit is contained in:
@@ -192,8 +192,8 @@
|
|||||||
delete this._baselines[name];
|
delete this._baselines[name];
|
||||||
},
|
},
|
||||||
|
|
||||||
reportInteraction: function(eventName) {
|
reportInteraction: function(eventName, opt_msg) {
|
||||||
this.reporter(INTERACTION_TYPE, this.category, eventName);
|
this.reporter(INTERACTION_TYPE, this.category, eventName, opt_msg);
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -15,7 +15,11 @@ limitations under the License.
|
|||||||
-->
|
-->
|
||||||
|
|
||||||
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
||||||
|
<link rel="import" href="../../core/gr-reporting/gr-reporting.html">
|
||||||
<dom-module id="gr-ranged-comment-layer">
|
<dom-module id="gr-ranged-comment-layer">
|
||||||
|
<template>
|
||||||
|
<gr-reporting id="reporting" category="comments"></gr-reporting>
|
||||||
|
</template>
|
||||||
<script src="../gr-diff-highlight/gr-annotation.js"></script>
|
<script src="../gr-diff-highlight/gr-annotation.js"></script>
|
||||||
<script src="gr-ranged-comment-layer.js"></script>
|
<script src="gr-ranged-comment-layer.js"></script>
|
||||||
</dom-module>
|
</dom-module>
|
||||||
|
|||||||
@@ -20,6 +20,8 @@
|
|||||||
var RANGE_HIGHLIGHT = 'range';
|
var RANGE_HIGHLIGHT = 'range';
|
||||||
var HOVER_HIGHLIGHT = 'rangeHighlight';
|
var HOVER_HIGHLIGHT = 'rangeHighlight';
|
||||||
|
|
||||||
|
var NORMALIZE_RANGE_EVENT = 'normalize-range';
|
||||||
|
|
||||||
Polymer({
|
Polymer({
|
||||||
is: 'gr-ranged-comment-layer',
|
is: 'gr-ranged-comment-layer',
|
||||||
|
|
||||||
@@ -181,10 +183,13 @@
|
|||||||
// @see Issue 5744
|
// @see Issue 5744
|
||||||
if (range.start >= range.end && range.start < line.text.length) {
|
if (range.start >= range.end && range.start < line.text.length) {
|
||||||
range.end = line.text.length;
|
range.end = line.text.length;
|
||||||
|
this.$.reporting.reportInteraction(NORMALIZE_RANGE_EVENT,
|
||||||
|
'Modified invalid comment range on l.' + lineNum +
|
||||||
|
' of the ' + side + ' side');
|
||||||
}
|
}
|
||||||
|
|
||||||
return range;
|
return range;
|
||||||
})
|
}.bind(this))
|
||||||
.sort(function(a, b) {
|
.sort(function(a, b) {
|
||||||
// Sort the ranges so that hovering highlights are on top.
|
// Sort the ranges so that hovering highlights are on top.
|
||||||
return a.hovering && !b.hovering ? 1 : 0;
|
return a.hovering && !b.hovering ? 1 : 0;
|
||||||
|
|||||||
Reference in New Issue
Block a user