Fix suggest reviewers when requested without limit option
According to documentation default limit is used when limit is not passed (rest-api-changes.txt): "If result limit is not passed, then the default 10 is used." Without this change, limit field got not initialized properly when in an empty result in any case. Change-Id: I2fddcd589cb9c39d73499e6eaa927cacd21d33d7
This commit is contained in:
committed by
Dave Borowitz
parent
3862ba2897
commit
ad060ec871
@@ -191,6 +191,21 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
|
|||||||
assertEquals(2, reviewers.size());
|
assertEquals(2, reviewers.size());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void suggestReviewersWithoutLimitOptionSpecified() throws Exception {
|
||||||
|
String changeId = createChange().getChangeId();
|
||||||
|
String query = "users3";
|
||||||
|
List<SuggestedReviewerInfo> suggestedReviewerInfos = newGson().fromJson(
|
||||||
|
adminSession.get("/changes/"
|
||||||
|
+ changeId
|
||||||
|
+ "/suggest_reviewers?q="
|
||||||
|
+ query)
|
||||||
|
.getReader(),
|
||||||
|
new TypeToken<List<SuggestedReviewerInfo>>() {}
|
||||||
|
.getType());
|
||||||
|
assertEquals(1, suggestedReviewerInfos.size());
|
||||||
|
}
|
||||||
|
|
||||||
private List<SuggestedReviewerInfo> suggestReviewers(RestSession session,
|
private List<SuggestedReviewerInfo> suggestReviewers(RestSession session,
|
||||||
String changeId, String query, int n) throws IOException {
|
String changeId, String query, int n) throws IOException {
|
||||||
return newGson().fromJson(
|
return newGson().fromJson(
|
||||||
|
|||||||
@@ -115,6 +115,7 @@ public class SuggestReviewers implements RestReadView<ChangeResource> {
|
|||||||
this.reviewerSuggestionCache = reviewerSuggestionCache;
|
this.reviewerSuggestionCache = reviewerSuggestionCache;
|
||||||
this.maxSuggestedReviewers =
|
this.maxSuggestedReviewers =
|
||||||
cfg.getInt("suggest", "maxSuggestedReviewers", DEFAULT_MAX_SUGGESTED);
|
cfg.getInt("suggest", "maxSuggestedReviewers", DEFAULT_MAX_SUGGESTED);
|
||||||
|
this.limit = this.maxSuggestedReviewers;
|
||||||
this.fullTextMaxMatches =
|
this.fullTextMaxMatches =
|
||||||
cfg.getInt("suggest", "fullTextSearchMaxMatches",
|
cfg.getInt("suggest", "fullTextSearchMaxMatches",
|
||||||
DEFAULT_MAX_MATCHES);
|
DEFAULT_MAX_MATCHES);
|
||||||
|
|||||||
Reference in New Issue
Block a user