diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/GarbageCollectionResult.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/GarbageCollectionResult.java index a052f4f306..0156b7dbfe 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/GarbageCollectionResult.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/GarbageCollectionResult.java @@ -39,7 +39,7 @@ public class GarbageCollectionResult { } public static class Error { - public static enum Type { + public enum Type { /** Git garbage collection was already scheduled for this project */ GC_ALREADY_SCHEDULED, diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchScript.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchScript.java index f23afb1ccf..5167fe6da0 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchScript.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchScript.java @@ -27,11 +27,11 @@ import org.eclipse.jgit.diff.Edit; import java.util.List; public class PatchScript { - public static enum DisplayMethod { + public enum DisplayMethod { NONE, DIFF, IMG } - public static enum FileMode { + public enum FileMode { FILE, SYMLINK, GITLINK } diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/PermissionRule.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/PermissionRule.java index 5aeb7971be..c1289f51c3 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/PermissionRule.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/PermissionRule.java @@ -17,7 +17,7 @@ package com.google.gerrit.common.data; public class PermissionRule implements Comparable { public static final String FORCE_PUSH = "Force Push"; public static final String FORCE_EDIT = "Force Edit"; - public static enum Action { + public enum Action { ALLOW, DENY, BLOCK, INTERACTIVE, BATCH diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitRecord.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitRecord.java index 5a32fcfc52..9dccf0cc4a 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitRecord.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitRecord.java @@ -23,7 +23,7 @@ import java.util.Objects; * Describes the state required to submit a change. */ public class SubmitRecord { - public static enum Status { + public enum Status { /** The change is ready for submission. */ OK, @@ -49,7 +49,7 @@ public class SubmitRecord { public String errorMessage; public static class Label { - public static enum Status { + public enum Status { /** * This label provides what is necessary for submission. *

diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitTypeRecord.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitTypeRecord.java index cd226effb7..b6ce797ad8 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitTypeRecord.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/SubmitTypeRecord.java @@ -20,7 +20,7 @@ import com.google.gerrit.extensions.client.SubmitType; * Describes the submit type for a change. */ public class SubmitTypeRecord { - public static enum Status { + public enum Status { /** The type was computed successfully */ OK, diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java index e6ce6b2ee4..0364b47dd0 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java @@ -66,7 +66,7 @@ public class ReviewInput { */ public String onBehalfOf; - public static enum DraftHandling { + public enum DraftHandling { /** Delete pending drafts on this revision only. */ DELETE, @@ -80,7 +80,7 @@ public class ReviewInput { PUBLISH_ALL_REVISIONS } - public static enum NotifyHandling { + public enum NotifyHandling { NONE, OWNER, OWNER_REVIEWERS, ALL } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/Projects.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/Projects.java index 0e848b9c19..cd738f074e 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/Projects.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/Projects.java @@ -61,7 +61,7 @@ public interface Projects { ListRequest list(); public abstract class ListRequest { - public static enum FilterType { + public enum FilterType { CODE, PARENT_CANDIDATES, PERMISSIONS, ALL } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java index 703f7b3905..59b222c00c 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java @@ -32,7 +32,7 @@ public class DiffPreferencesInfo { public static final short[] CONTEXT_CHOICES = {3, 10, 25, 50, 75, 100, WHOLE_FILE_CONTEXT}; - public static enum Whitespace { + public enum Whitespace { IGNORE_NONE, IGNORE_TRAILING, IGNORE_LEADING_AND_TRAILING, diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java index cb3ab596cf..9754f12ebd 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java @@ -27,11 +27,11 @@ public class GeneralPreferencesInfo { public static final int[] PAGESIZE_CHOICES = {10, 25, 50, 100}; /** Preferred method to download a change. */ - public static enum DownloadCommand { + public enum DownloadCommand { REPO_DOWNLOAD, PULL, CHECKOUT, CHERRY_PICK, FORMAT_PATCH } - public static enum DateFormat { + public enum DateFormat { /** US style dates: Apr 27, Feb 14, 2010 */ STD("MMM d", "MMM d, yyyy"), @@ -64,7 +64,7 @@ public class GeneralPreferencesInfo { } } - public static enum ReviewCategoryStrategy { + public enum ReviewCategoryStrategy { NONE, NAME, EMAIL, @@ -72,18 +72,18 @@ public class GeneralPreferencesInfo { ABBREV } - public static enum DiffView { + public enum DiffView { SIDE_BY_SIDE, UNIFIED_DIFF } - public static enum EmailStrategy { + public enum EmailStrategy { ENABLED, CC_ON_OWN_COMMENTS, DISABLED } - public static enum TimeFormat { + public enum TimeFormat { /** 12-hour clock: 1:15 am, 2:13 pm */ HHMM_12("h:mm a"), diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/DiffInfo.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/DiffInfo.java index 58b2d390ab..3df4b86f20 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/DiffInfo.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/DiffInfo.java @@ -35,7 +35,7 @@ public class DiffInfo { // Binary file public Boolean binary; - public static enum IntraLineStatus { + public enum IntraLineStatus { OK, TIMEOUT, FAILURE diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/ProblemInfo.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/ProblemInfo.java index d04b34605e..4dd910d147 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/ProblemInfo.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/ProblemInfo.java @@ -15,7 +15,7 @@ package com.google.gerrit.extensions.common; public class ProblemInfo { - public static enum Status { + public enum Status { FIXED, FIX_FAILED } diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabelText.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabelText.java index 4d1b837331..4a7f36e219 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabelText.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabelText.java @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.i18n.client.Constants; interface CopyableLabelText extends Constants { - static final CopyableLabelText I = GWT.create(CopyableLabelText.class); + final CopyableLabelText I = GWT.create(CopyableLabelText.class); String tooltip(); String copied(); diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java index 6eaa7fd733..a84835e991 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java @@ -102,7 +102,7 @@ class AttMap { } } - private static interface Tag { + private interface Tag { void assertSafe(String name, String value); } diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/Tooltip.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/Tooltip.java index e3ab034318..6a2e4447ac 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/Tooltip.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/Tooltip.java @@ -23,7 +23,7 @@ import com.google.gwt.user.client.ui.UIObject; /** Displays custom tooltip message below an element. */ public class Tooltip { interface Resources extends ClientBundle { - static final Resources I = GWT.create(Resources.class); + final Resources I = GWT.create(Resources.class); @Source("tooltip.css") Css css(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java index 28943ab018..396bc8abdf 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java @@ -35,7 +35,7 @@ abstract class ActionMessageBox extends Composite { interface Binder extends UiBinder {} private static final Binder uiBinder = GWT.create(Binder.class); - static interface Style extends CssResource { + interface Style extends CssResource { String popup(); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java index 71cc7fb0e8..41f0f21303 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java @@ -95,7 +95,7 @@ public class FileTable extends FlowPanel { String restoreDelete(); } - public static enum Mode { + public enum Mode { REVIEW, EDIT } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java index f53c1a3bcf..6c27ed9435 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java @@ -50,7 +50,7 @@ class Message extends Composite { interface Binder extends UiBinder {} private static final Binder uiBinder = GWT.create(Binder.class); - static interface Style extends CssResource { + interface Style extends CssResource { String closed(); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Resources.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Resources.java index 4fc76c18ab..9abeadd31d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Resources.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Resources.java @@ -20,8 +20,8 @@ import com.google.gwt.resources.client.CssResource; public interface Resources extends ClientBundle { public static final Resources I = GWT.create(Resources.class); - static final ChangeConstants C = GWT.create(ChangeConstants.class); - static final ChangeMessages M = GWT.create(ChangeMessages.class); + final ChangeConstants C = GWT.create(ChangeConstants.class); + final ChangeMessages M = GWT.create(ChangeMessages.class); @Source("common.css") Style style(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java index 096dbd0df7..0f22a237d7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java @@ -19,11 +19,11 @@ import com.google.gwt.core.client.JavaScriptObject; import com.google.gwt.core.client.JsArray; public class ReviewInput extends JavaScriptObject { - public static enum NotifyHandling { + public enum NotifyHandling { NONE, OWNER, OWNER_REVIEWERS, ALL } - public static enum DraftHandling { + public enum DraftHandling { DELETE, PUBLISH, KEEP, PUBLISH_ALL_REVISIONS } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarredChanges.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarredChanges.java index 8750389b52..43b3b800f4 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarredChanges.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarredChanges.java @@ -37,7 +37,7 @@ public class StarredChanges { private static final Event.Type TYPE = new Event.Type<>(); /** Handler that can receive notifications of a change's starred status. */ - public static interface ChangeStarHandler { + public interface ChangeStarHandler { void onChangeStar(ChangeStarEvent event); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java index a554df6b85..76d09a234b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java @@ -68,7 +68,7 @@ public class Header extends Composite { Resources.I.style().ensureInjected(); } - private static enum ReviewedState { + private enum ReviewedState { AUTO_REVIEW, LOADED } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PublishedBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PublishedBox.java index cfa6e0093f..e497e8bd4a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PublishedBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PublishedBox.java @@ -46,7 +46,7 @@ class PublishedBox extends CommentBox { interface Binder extends UiBinder {} private static final Binder uiBinder = GWT.create(Binder.class); - static interface Style extends CssResource { + interface Style extends CssResource { String closed(); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Resources.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Resources.java index 0359df3e7a..fbe025607b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Resources.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Resources.java @@ -20,7 +20,7 @@ import com.google.gwt.resources.client.ImageResource; /** Resources used by diff. */ interface Resources extends ClientBundle { - static final Resources I = GWT.create(Resources.class); + final Resources I = GWT.create(Resources.class); @Source("CommentBox.css") CommentBox.Style style(); @Source("Scrollbar.css") Scrollbar.Style scrollbarStyle(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditConstants.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditConstants.java index e95fdfcdf6..461e2d61ac 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditConstants.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditConstants.java @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.i18n.client.Constants; interface EditConstants extends Constants { - static final EditConstants I = GWT.create(EditConstants.class); + final EditConstants I = GWT.create(EditConstants.class); String closeUnsavedChanges(); String cancelUnsavedChanges(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java index 721f1cdb5b..1068b3ec42 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java @@ -70,7 +70,7 @@ public abstract class Screen extends View { public void registerKeys() { } - private static enum Cols { + private enum Cols { West, Title, East, FarEast } diff --git a/gerrit-gwtui/src/main/java/net/codemirror/lib/Lib.java b/gerrit-gwtui/src/main/java/net/codemirror/lib/Lib.java index a3b1cf453f..adf4fe4cb8 100644 --- a/gerrit-gwtui/src/main/java/net/codemirror/lib/Lib.java +++ b/gerrit-gwtui/src/main/java/net/codemirror/lib/Lib.java @@ -21,7 +21,7 @@ import com.google.gwt.resources.client.DataResource.DoNotEmbed; import com.google.gwt.resources.client.ExternalTextResource; interface Lib extends ClientBundle { - static final Lib I = GWT.create(Lib.class); + final Lib I = GWT.create(Lib.class); @Source("cm.css") ExternalTextResource css(); diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/PluginServletContext.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/PluginServletContext.java index af34c5fe06..0889c855eb 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/PluginServletContext.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/PluginServletContext.java @@ -208,7 +208,7 @@ class PluginServletContext { } } - static interface API { + interface API { String getContextPath(); String getInitParameter(String name); @SuppressWarnings("rawtypes") diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java index 3c1c6e9c66..c89d7ca602 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java @@ -121,7 +121,7 @@ public class BaseServiceImplementation { } /** Arbitrary action to run with a database connection. */ - public static interface Action { + public interface Action { /** * Perform this action, returning the onSuccess value. * diff --git a/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/DiscoveryResult.java b/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/DiscoveryResult.java index 37051da0d5..2ee3b6ba43 100644 --- a/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/DiscoveryResult.java +++ b/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/DiscoveryResult.java @@ -17,7 +17,7 @@ package com.google.gerrit.httpd.auth.openid; import java.util.Map; final class DiscoveryResult { - static enum Status { + enum Status { /** Provider was discovered and {@code providerUrl} is valid. */ VALID, diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/rules/PrologCompiler.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/rules/PrologCompiler.java index 064cc19680..8d3c7668c0 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/rules/PrologCompiler.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/rules/PrologCompiler.java @@ -66,7 +66,7 @@ public class PrologCompiler implements Callable { PrologCompiler create(Repository git); } - public static enum Status { + public enum Status { NO_RULES, COMPILED } diff --git a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Account.java b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Account.java index 327a5b8f8a..3af572a1c9 100644 --- a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Account.java +++ b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Account.java @@ -59,7 +59,7 @@ import java.sql.Timestamp; * */ public final class Account { - public static enum FieldName { + public enum FieldName { FULL_NAME, USER_NAME, REGISTER_NEW_EMAIL } diff --git a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java index 5c70d3cb5a..3a1f5a524a 100644 --- a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java +++ b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java @@ -281,7 +281,7 @@ public final class Change { * codes ('A'..'Z') indicate a change that is closed and cannot be further * modified. * */ - public static enum Status { + public enum Status { /** * Change is open and pending review, or review is in progress. * diff --git a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Patch.java b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Patch.java index 3637914582..d80caf454e 100644 --- a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Patch.java +++ b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Patch.java @@ -68,7 +68,7 @@ public final class Patch { } /** Type of modification made to the file path. */ - public static enum ChangeType implements CodedEnum { + public enum ChangeType implements CodedEnum { /** Path is being created/introduced by this patch. */ ADDED('A'), @@ -113,7 +113,7 @@ public final class Patch { } /** Type of formatting for this patch. */ - public static enum PatchType implements CodedEnum { + public enum PatchType implements CodedEnum { /** * A textual difference between two versions. * diff --git a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchLineComment.java b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchLineComment.java index a4c5da5e91..39cab45cc3 100644 --- a/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchLineComment.java +++ b/gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchLineComment.java @@ -60,7 +60,7 @@ public final class PatchLineComment { public static final char STATUS_DRAFT = 'd'; public static final char STATUS_PUBLISHED = 'P'; - public static enum Status { + public enum Status { DRAFT(STATUS_DRAFT), PUBLISHED(STATUS_PUBLISHED); diff --git a/gerrit-server/src/main/java/com/google/gerrit/metrics/Description.java b/gerrit-server/src/main/java/com/google/gerrit/metrics/Description.java index 43e5c8a91f..48358b7a9e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/metrics/Description.java +++ b/gerrit-server/src/main/java/com/google/gerrit/metrics/Description.java @@ -44,7 +44,7 @@ public class Description { } } - public static enum FieldOrdering { + public enum FieldOrdering { /** Default ordering places fields at end of the parent metric name. */ AT_END, diff --git a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java index 26c0fd0e2f..de54a0b014 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java +++ b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java @@ -54,7 +54,7 @@ public class PrologEnvironment extends BufferingPrologControl { private static final Logger log = LoggerFactory.getLogger(PrologEnvironment.class); - public static interface Factory { + public interface Factory { /** * Construct a new Prolog interpreter. * diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java index 9d580f5b38..0f78581b57 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java @@ -39,7 +39,7 @@ import java.util.Map; /** Access control management for server-wide capabilities. */ public class CapabilityControl { - public static interface Factory { + public interface Factory { CapabilityControl create(CurrentUser user); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java index f16c3ea0f3..190db5f3ab 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateAccount.java @@ -66,7 +66,7 @@ public class CreateAccount implements RestModifyView { public List groups; } - public static interface Factory { + public interface Factory { CreateAccount create(String username); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateEmail.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateEmail.java index a78c23cacb..45dd971d4b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateEmail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CreateEmail.java @@ -42,7 +42,7 @@ import org.slf4j.LoggerFactory; public class CreateEmail implements RestModifyView { private static final Logger log = LoggerFactory.getLogger(CreateEmail.class); - public static interface Factory { + public interface Factory { CreateEmail create(String email); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java index fe1a4b7f39..6af3e79547 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java @@ -77,7 +77,7 @@ import java.util.Set; import java.util.concurrent.ExecutorService; public class ChangeInserter extends BatchUpdate.InsertChangeOp { - public static interface Factory { + public interface Factory { ChangeInserter create(Change.Id cid, RevCommit rc, String refName); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java index 1853438cd0..a70716af75 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java @@ -68,7 +68,7 @@ public class PatchSetInserter extends BatchUpdate.Op { private static final Logger log = LoggerFactory.getLogger(PatchSetInserter.class); - public static interface Factory { + public interface Factory { PatchSetInserter create(RefControl refControl, PatchSet.Id psId, RevCommit commit); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerResource.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerResource.java index d48151b670..aac9252f9b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerResource.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerResource.java @@ -28,7 +28,7 @@ public class ReviewerResource implements RestResource { public static final TypeLiteral> REVIEWER_KIND = new TypeLiteral>() {}; - public static interface Factory { + public interface Factory { ReviewerResource create(ChangeResource change, Account.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/ListCaches.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/ListCaches.java index 653f5bd2d8..4183e611fc 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/ListCaches.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/ListCaches.java @@ -41,7 +41,7 @@ import java.util.TreeMap; public class ListCaches implements RestReadView { private final DynamicMap> cacheMap; - public static enum OutputFormat { + public enum OutputFormat { LIST, TEXT_LIST } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/PostCaches.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/PostCaches.java index 5178210099..33a458ec1f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/PostCaches.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/PostCaches.java @@ -52,7 +52,7 @@ public class PostCaches implements RestModifyView { } } - public static enum Operation { + public enum Operation { FLUSH_ALL, FLUSH } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditModifier.java b/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditModifier.java index 1528751217..0cd80f23ce 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditModifier.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditModifier.java @@ -82,7 +82,7 @@ import java.util.TimeZone; @Singleton public class ChangeEditModifier { - private static enum TreeOperation { + private enum TreeOperation { CHANGE_ENTRY, DELETE_ENTRY, RENAME_ENTRY, diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java index e9ad8b73a5..e32e6ad346 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java @@ -100,7 +100,7 @@ public class BatchUpdate implements AutoCloseable { } /** Order of execution of the various phases. */ - public static enum Order { + public enum Order { /** * Update the repository and execute all ref updates before touching the * database. diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/GroupCollector.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/GroupCollector.java index 8f9add5708..d83226024d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/GroupCollector.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/GroupCollector.java @@ -103,7 +103,7 @@ public class GroupCollector { return rsrc.getPatchSet().getGroups(); } - private static interface Lookup { + private interface Lookup { List lookup(PatchSet.Id psId) throws OrmException, NoSuchChangeException; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java index 4a2eee442e..e83248395d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java @@ -106,7 +106,7 @@ public class MergeUtil { : MergeStrategy.RESOLVE; } - public static interface Factory { + public interface Factory { MergeUtil create(ProjectState project); MergeUtil create(ProjectState project, boolean useContentMerge); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/NotifyConfig.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/NotifyConfig.java index abc53f4069..f88c2ce3e0 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/NotifyConfig.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/NotifyConfig.java @@ -24,7 +24,7 @@ import java.util.EnumSet; import java.util.Set; public class NotifyConfig implements Comparable { - public static enum Header { + public enum Header { TO, CC, BCC } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java index 954e412b1d..a0c93127b5 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java @@ -262,7 +262,7 @@ public class WorkQueue { *

  • {@link #DONE}: finished executing, if not periodic.
  • * */ - public static enum State { + public enum State { // Ordered like this so ordinal matches the order we would // prefer to see tasks sorted in: done before running, // running before ready, ready before sleeping. diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java index b069ca9727..5e84fd3370 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java @@ -66,7 +66,7 @@ public class CommitValidators { private static final Logger log = LoggerFactory .getLogger(CommitValidators.class); - public static enum Policy { + public enum Policy { /** Use {@link #validateForGerritCommits}. */ GERRIT, diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/group/CreateGroup.java b/gerrit-server/src/main/java/com/google/gerrit/server/group/CreateGroup.java index f3f12a1d88..dbcad99b99 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/group/CreateGroup.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/group/CreateGroup.java @@ -56,7 +56,7 @@ import java.util.Locale; @RequiresCapability(GlobalCapability.CREATE_GROUP) public class CreateGroup implements RestModifyView { - public static interface Factory { + public interface Factory { CreateGroup create(@Assisted String name); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/AbandonedSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/AbandonedSender.java index dbd0438483..1e8bdf4f46 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/AbandonedSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/AbandonedSender.java @@ -24,7 +24,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a change being abandoned by its owner. */ public class AbandonedSender extends ReplyToChangeSender { - public static interface Factory extends + public interface Factory extends ReplyToChangeSender.Factory { @Override AbandonedSender create(Project.NameKey project, Change.Id change); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/AddReviewerSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/AddReviewerSender.java index 98fc4a023e..c9e42ad4de 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/AddReviewerSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/AddReviewerSender.java @@ -23,7 +23,7 @@ import com.google.inject.assistedinject.Assisted; /** Asks a user to review a change. */ public class AddReviewerSender extends NewChangeSender { - public static interface Factory { + public interface Factory { AddReviewerSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java index c845c28a47..a39e43aeea 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java @@ -52,7 +52,7 @@ public class CommentSender extends ReplyToChangeSender { private static final Logger log = LoggerFactory .getLogger(CommentSender.class); - public static interface Factory { + public interface Factory { CommentSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CreateChangeSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CreateChangeSender.java index 87bfa375d6..2110e375ce 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CreateChangeSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CreateChangeSender.java @@ -33,7 +33,7 @@ public class CreateChangeSender extends NewChangeSender { private static final Logger log = LoggerFactory.getLogger(CreateChangeSender.class); - public static interface Factory { + public interface Factory { CreateChangeSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/DeleteVoteSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/DeleteVoteSender.java index 05937d5c1d..d861109c38 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/DeleteVoteSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/DeleteVoteSender.java @@ -24,7 +24,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a vote that was removed from a change. */ public class DeleteVoteSender extends ReplyToChangeSender { - public static interface Factory extends + public interface Factory extends ReplyToChangeSender.Factory { @Override DeleteVoteSender create(Project.NameKey project, Change.Id change); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergeFailSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergeFailSender.java index 3dfbcda31f..3883786d88 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergeFailSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergeFailSender.java @@ -23,7 +23,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a change failing to merged. */ public class MergeFailSender extends ReplyToChangeSender { - public static interface Factory { + public interface Factory { MergeFailSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergedSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergedSender.java index 7271c181e7..f6c3d0f59f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergedSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MergedSender.java @@ -31,7 +31,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a change successfully merged. */ public class MergedSender extends ReplyToChangeSender { - public static interface Factory { + public interface Factory { MergedSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java index 6bee3e8a82..df9f20e7b5 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java @@ -31,7 +31,7 @@ import java.util.Set; /** Send notice of new patch sets for reviewers. */ public class ReplacePatchSetSender extends ReplyToChangeSender { - public static interface Factory { + public interface Factory { ReplacePatchSetSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplyToChangeSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplyToChangeSender.java index 8eadeefa19..dd922d3f5c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplyToChangeSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplyToChangeSender.java @@ -22,7 +22,7 @@ import com.google.gwtorm.server.OrmException; /** Alert a user to a reply to a change, usually commentary made during review. */ public abstract class ReplyToChangeSender extends ChangeEmail { - public static interface Factory { + public interface Factory { T create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RestoredSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RestoredSender.java index 0808090245..d946eb292a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RestoredSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RestoredSender.java @@ -24,7 +24,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a change being restored by its owner. */ public class RestoredSender extends ReplyToChangeSender { - public static interface Factory extends + public interface Factory extends ReplyToChangeSender.Factory { @Override RestoredSender create(Project.NameKey project, Change.Id id); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RevertedSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RevertedSender.java index 55438fea29..2c9c37e2b3 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RevertedSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RevertedSender.java @@ -24,7 +24,7 @@ import com.google.inject.assistedinject.Assisted; /** Send notice about a change being reverted. */ public class RevertedSender extends ReplyToChangeSender { - public static interface Factory { + public interface Factory { RevertedSender create(Project.NameKey project, Change.Id id); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java index 075a3768fb..e263c6a704 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java @@ -57,7 +57,7 @@ public class SmtpEmailSender implements EmailSender { } } - public static enum Encryption { + public enum Encryption { NONE, SSL, TLS } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineDiff.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineDiff.java index 46def59ef7..60b97c7e14 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineDiff.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineDiff.java @@ -37,7 +37,7 @@ import java.util.List; public class IntraLineDiff implements Serializable { static final long serialVersionUID = IntraLineDiffKey.serialVersionUID; - public static enum Status implements CodedEnum { + public enum Status implements CodedEnum { EDIT_LIST('e'), DISABLED('D'), TIMEOUT('T'), ERROR('E'); private final char code; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java index de70478d92..dd15cfc6f7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java @@ -40,7 +40,7 @@ import java.util.regex.Pattern; class IntraLineLoader implements Callable { static final Logger log = LoggerFactory.getLogger(IntraLineLoader.class); - static interface Factory { + interface Factory { IntraLineLoader create(IntraLineDiffKey key, IntraLineDiffArgs args); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/HttpModuleGenerator.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/HttpModuleGenerator.java index dd0ce67062..73effa14f7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/HttpModuleGenerator.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/HttpModuleGenerator.java @@ -18,7 +18,7 @@ package com.google.gerrit.server.plugins; public interface HttpModuleGenerator extends ModuleGenerator { void export(String javascript); - static class NOP extends ModuleGenerator.NOP + class NOP extends ModuleGenerator.NOP implements HttpModuleGenerator { @Override public void export(String javascript) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/ModuleGenerator.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/ModuleGenerator.java index ae8bb0ce0e..7818591bb0 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/ModuleGenerator.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/ModuleGenerator.java @@ -27,7 +27,7 @@ public interface ModuleGenerator { Module create() throws InvalidPluginException; - static class NOP implements ModuleGenerator { + class NOP implements ModuleGenerator { @Override public void setPluginName(String name) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java index 588bc6d71b..3154b4e712 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java @@ -32,7 +32,7 @@ import java.util.jar.Attributes; import java.util.jar.Manifest; public abstract class Plugin { - public static enum ApiType { + public enum ApiType { EXTENSION, PLUGIN, JS } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java index 83f69ee3c0..94b9f4a143 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java @@ -64,7 +64,7 @@ public class CreateBranch implements RestModifyView { public String revision; } - public static interface Factory { + public interface Factory { CreateBranch create(String ref); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java index fec858a6c4..a73ed0ec29 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java @@ -80,7 +80,7 @@ import java.util.List; @RequiresCapability(GlobalCapability.CREATE_PROJECT) public class CreateProject implements RestModifyView { - public static interface Factory { + public interface Factory { CreateProject create(String name); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java index b0ab94bc75..907b925a46 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java @@ -76,7 +76,7 @@ import java.util.TreeSet; public class ListProjects implements RestReadView { private static final Logger log = LoggerFactory.getLogger(ListProjects.class); - public static enum FilterType { + public enum FilterType { CODE { @Override boolean matches(Repository git) throws IOException { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java index b07b7f2355..512ca866a5 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java @@ -69,7 +69,7 @@ public class OutputStreamQuery { private static final DateTimeFormatter dtf = DateTimeFormat.forPattern("yyyy-MM-dd HH:mm:ss zzz"); - public static enum OutputFormat { + public enum OutputFormat { TEXT, JSON } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/DataSourceProvider.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/DataSourceProvider.java index 0c3bf673e4..b362a2e5a6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/DataSourceProvider.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/DataSourceProvider.java @@ -91,7 +91,7 @@ public class DataSourceProvider implements Provider, } } - public static enum Context { + public enum Context { SINGLE_USER, MULTI_USER } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java b/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java index f59bba947c..37383b75e6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java @@ -135,7 +135,7 @@ public class ToolsCatalog { /** A file served out of the tools root directory. */ public static class Entry { - public static enum Type { + public enum Type { DIR, FILE } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/util/TreeFormatter.java b/gerrit-server/src/main/java/com/google/gerrit/server/util/TreeFormatter.java index cd559ee186..883f972ea2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/util/TreeFormatter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/util/TreeFormatter.java @@ -19,7 +19,7 @@ import java.util.SortedSet; public class TreeFormatter { - public static interface TreeNode { + public interface TreeNode { String getDisplayName(); boolean isVisible(); SortedSet getChildren(); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java index ec49f5cbf5..fd48220149 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java @@ -488,12 +488,12 @@ public abstract class BaseCommand implements Command { } /** Runnable function which can throw an exception. */ - public static interface CommandRunnable { + public interface CommandRunnable { void run() throws Exception; } /** Runnable function which can retrieve a project name related to the task */ - public static interface ProjectCommandRunnable extends CommandRunnable { + public interface ProjectCommandRunnable extends CommandRunnable { // execute parser command before running, in order to be able to retrieve // project name void executeParseCommand() throws Exception; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java index f47c4d00d4..5fd8932034 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java @@ -140,7 +140,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener { private static final Logger sshDaemonLog = LoggerFactory.getLogger(SshDaemon.class); - public static enum SshSessionBackend { + public enum SshSessionBackend { MINA, NIO2 } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java index 0529b90486..4c930c8071 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java @@ -51,7 +51,7 @@ public class QueryShell { QueryShell create(@Assisted InputStream in, @Assisted OutputStream out); } - public static enum OutputFormat { + public enum OutputFormat { PRETTY, JSON, JSON_SINGLE } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetLoggingLevelCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetLoggingLevelCommand.java index 49edf145d7..6277eb4943 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetLoggingLevelCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetLoggingLevelCommand.java @@ -40,7 +40,7 @@ public class SetLoggingLevelCommand extends SshCommand { private static final String LOG_CONFIGURATION = "log4j.properties"; private static final String JAVA_OPTIONS_LOG_CONFIG = "log4j.configuration"; - private static enum LevelOption { + private enum LevelOption { ALL, TRACE, DEBUG, diff --git a/plugins/replication b/plugins/replication index de1e8f7604..701677ac8a 160000 --- a/plugins/replication +++ b/plugins/replication @@ -1 +1 @@ -Subproject commit de1e8f7604376b868ea24f779a06c32139cb4cf3 +Subproject commit 701677ac8a09aecc591f219322d18c99dd545efb