opendev/gerrit
Code Issues Proposed changes

Move TimeUtil into own package and let it have its own java_library

Browse Source 
This further reduces the dependencies for the logging/ package as now it
no longer needs to depend on java/com/google/gerrit/common:server, which
is kind of a large package.

The @GwtIncompatible annatation is removed from TimeUtil since this
class is no longer in a package that is shared with GWT.

Change-Id: I9c1c84d2b8feffddb6f8e955035a6a48f9f248c3
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-09-18 17:55:51 +02:00
parent 0a7075fea6
commit ad19626f94
144 changed files with 160 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/server/schema/BUILD
View File

@@ -12,6 +12,7 @@ java_library(
"//java/com/google/gerrit/metrics",
"//java/com/google/gerrit/reviewdb:server",
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/server/util/time",
"//java/org/eclipse/jgit:server",
"//lib:guava",
"//lib:gwtorm",

2
java/com/google/gerrit/server/schema/GroupBundle.java
View File

@@ -31,7 +31,6 @@ import com.google.common.collect.MultimapBuilder;
import com.google.common.collect.Multimaps;
import com.google.common.collect.Streams;
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.common.TimeUtil;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.client.AccountGroupById;
@@ -44,6 +43,7 @@ import com.google.gerrit.reviewdb.server.ReviewDbWrapper;
import com.google.gerrit.server.group.InternalGroup;
import com.google.gerrit.server.group.db.AuditLogReader;
import com.google.gerrit.server.group.db.GroupConfig;
import com.google.gerrit.server.util.time.TimeUtil;
import com.google.gwtorm.jdbc.JdbcSchema;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;

2
java/com/google/gerrit/server/schema/GroupRebuilder.java
View File

@@ -25,7 +25,6 @@ import com.google.common.collect.ListMultimap;
import com.google.common.collect.MultimapBuilder;
import com.google.common.collect.Sets;
import com.google.gerrit.common.Nullable;
import com.google.gerrit.common.TimeUtil;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.client.AccountGroupById;
@@ -43,6 +42,7 @@ import com.google.gerrit.server.group.db.InternalGroupCreation;
import com.google.gerrit.server.group.db.InternalGroupUpdate;
import com.google.gerrit.server.group.db.InternalGroupUpdate.MemberModification;
import com.google.gerrit.server.group.db.InternalGroupUpdate.SubgroupModification;
import com.google.gerrit.server.util.time.TimeUtil;
import com.google.gwtorm.server.OrmDuplicateKeyException;
import java.io.IOException;
import java.sql.Timestamp;