opendev/gerrit
Code Issues Proposed changes

ChangeNotificationsIT: Don't trigger review after setting ready

Browse Source 
The comment on this line is inaccurate: PolyGerrit does not set a change
ready by calling first the Set Ready endpoint followed by the Post
Review endpoint. In fact, it just does a single Post Review with
ready=true in the ReviewInput. This case was already handled by
ChangeNotificationsIT#commentOnWipChangeAndStartReview.

In fact, the extra review method should send no email at all, since
there is no message. Thus it was just a no-op and a distraction in these
tests.

Change-Id: I47d8d486145bd01cda2722ec388899bb3e5d1691
This commit is contained in:
Dave Borowitz
2019-02-05 14:28:24 -08:00
parent 520d92157a
commit ad38704c4c
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javatests/com/google/gerrit/acceptance/server/mail/ChangeNotificationsIT.java
View File

@@ -2294,8 +2294,6 @@ public class ChangeNotificationsIT extends AbstractNotificationTest {
private void startReview(StagedChange sc) throws Exception {
requestScopeOperations.setApiUser(sc.owner.getId());
gApi.changes().id(sc.changeId).setReadyForReview();
// PolyGerrit current immediately follows up with a review.
gApi.changes().id(sc.changeId).revision("current").review(ReviewInput.noScore());
}
private void setWorkInProgressByDefault(Project.NameKey p, InheritableBoolean v)